From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FA4813F434 for ; Sun, 26 Jan 2025 18:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737915189; cv=none; b=IH6PwBNDexduZDK7DvkppUYs4yxCYs69kZS7kisdtk/YIfiRkfBPLPu/9jIT7XddMIgsk1XvBQJU2n+7KJAKgehqWVce/SauJ/Ii0xsJmB/AKlHc9HQEuR5b99+qceAYGCs2w0ac1mkgL+4t/F3NV5U+j8hudthsjaKWQ+zi7fE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737915189; c=relaxed/simple; bh=2Z5f3Ho/goba7XKv9XKk65eWIRKrQfD9BWjYDKnQXMc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z4bQNG9c3dwcrnqH29lc+QLchuHTit38Q/CITM14ALpfqpGbNxfGBnRejnMa80MX+ogqAH9GFogRY+6ZyyhHzt5JMqXo4Zw8eUI+yowK6xegKHW99rcLQU8PiFBg4I5NDbvwZS/ezqpsdh1kEwh4PRYE4C2R97Xtz6obvm1+bvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T9gTnOdb; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T9gTnOdb" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3862ca8e0bbso3251007f8f.0 for ; Sun, 26 Jan 2025 10:13:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737915186; x=1738519986; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uuUC2RadicKmNdt+Kmu6m/kYLq/GvnYjtGgefyr2vUc=; b=T9gTnOdbK7kpsj1oMga8A/G5EB1ZbnV27HYJUXilpzi5+nz8t6oUWBwpvRKsSMztt6 A0Ms+juqlHmEVUwVzrxZxdn84QAIvvhHHz8FzcNLtXTAtO37oYtlJ/iJ4JaUqVV4FscN 8z1CcQmII5tJ7HsDO5Br3qHDzqYGFQpax2feEIkIiJMka6piqr+G8ZwA8rOzaSbZh6pu mMy2YAPFdRHM/8laRO1E/3nUm5gFbTFCgjMx8GnPx4lf5QzzcvzWRdzH1d/fyRqMK6T9 Cx96dy3vTJUmV+ftfq9a3r+TOnyRDz+UhCqV16dj8LtYJD1eKKlI2dN49Ve9JcLHpkyQ zctg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737915186; x=1738519986; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uuUC2RadicKmNdt+Kmu6m/kYLq/GvnYjtGgefyr2vUc=; b=YzlCFipeCiDhSfJ41/k19CjYjwWoDuZ158rSORG/5+6U2vqnj09zUp2ilBKgv4hfOk jOSxG7pkz2ubX0bNYqEw5bANDhapZMu1/pyKKJddc/8E7F4pYoB2eVMb2sOLzksrX1K7 VGOcctM3XzZuv0W1SGs3pqlhQjS83BznEmFdMT80eJL/w9JzbTIAccSIGJvNvzBEM9qV mljVikeQEsF4s7qSWf0vSy22luyjQ+xWDqyDaAalzzDCSEbIzcujR4pXLB1CIEU91ku2 uqtrlVWobMqNDrEk9UhMoS3sDpzteTyklZ+ym88iwoj/u14KB4vvKJJMEhyigJxapUT6 2FDw== X-Forwarded-Encrypted: i=1; AJvYcCW0U5Bw0qku6oFiu2Q5W7259+9bcyzDzHOVfAVOf14G84BvGCyNfmnW216p4f3nvfG2M24BYDNpNpxZ1DY=@vger.kernel.org X-Gm-Message-State: AOJu0YzEz2Dt+SAo90gihHfRSDpWtUIGbYMwRhsRC4dc/Gbw/O/gDKgj y+eDxkYpYpAdU3ThIjmAIlML5amEzzNj3oKzCIoeIi6V02zWbTgT X-Gm-Gg: ASbGncuWraAkOUqbNUuX0jbFgYRGEi4VC1L4CS5gmWvP+wf/X/C+uwrk0rPTWr3lz8W n1j7S9cMYM6G9sN8ymwklbLxlPfelzce5FEBaILKeO2c45BuDR3sAZzZZ2CwKuTAxRS+GP01fQJ 8P46VaO1S9tEs5tQxXSM4b6nsk38Dy62pZnUeT6tX8Ml/Bij9m8tCDrMUvO02M+nJ7Ksu2li3J1 6EKWGq5ActDsMjmuZbRB3YpWsL4Mb21LBfcjI4a7MdYntXNLfwuWzF+qtd/n2MuQyAtRnTKggNc XzYFwNUMIBWICo4B3y0v X-Google-Smtp-Source: AGHT+IGXvcULgIgx69vt973bLQNtKSFbRZpvKAGdjau0peUuwKgyDDJjdlVUkrLE+Jb9otnaJOCV9Q== X-Received: by 2002:a05:6000:1863:b0:385:e877:c037 with SMTP id ffacd0b85a97d-38bf57a7515mr37910617f8f.42.1737915185331; Sun, 26 Jan 2025 10:13:05 -0800 (PST) Received: from egonzo (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a1bb0besm8841008f8f.79.2025.01.26.10.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jan 2025 10:13:04 -0800 (PST) Date: Sun, 26 Jan 2025 19:13:01 +0100 From: Dave Penkler To: kernel test robot Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] staging: gpib: Remove depends on BROKEN Message-ID: References: <20250124105900.27592-4-dpenkler@gmail.com> <202501252218.eaGgSuN3-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202501252218.eaGgSuN3-lkp@intel.com> On Sat, Jan 25, 2025 at 10:16:20PM +0800, kernel test robot wrote: > Hi Dave, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on staging/staging-testing] > > url: https://github.com/intel-lab-lkp/linux/commits/Dave-Penkler/staging-gpib-Fix-pr_err-format-warning/20250124-190232 > base: staging/staging-testing > patch link: https://lore.kernel.org/r/20250124105900.27592-4-dpenkler%40gmail.com > patch subject: [PATCH 3/3] staging: gpib: Remove depends on BROKEN > config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20250125/202501252218.eaGgSuN3-lkp@intel.com/config) > compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250125/202501252218.eaGgSuN3-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202501252218.eaGgSuN3-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> drivers/staging/gpib/hp_82341/hp_82341.c:802:35: warning: unused variable 'hp_82341_pnp_table' [-Wunused-const-variable] > 802 | static const struct pnp_device_id hp_82341_pnp_table[] = { > | ^~~~~~~~~~~~~~~~~~ > 1 warning generated. > > > vim +/hp_82341_pnp_table +802 drivers/staging/gpib/hp_82341/hp_82341.c > > 6d4f8749cd5da8 Dave Penkler 2024-09-18 801 > 6d4f8749cd5da8 Dave Penkler 2024-09-18 @802 static const struct pnp_device_id hp_82341_pnp_table[] = { > 6d4f8749cd5da8 Dave Penkler 2024-09-18 803 {.id = "HWP1411"}, > 6d4f8749cd5da8 Dave Penkler 2024-09-18 804 {.id = ""} > 6d4f8749cd5da8 Dave Penkler 2024-09-18 805 }; > 6d4f8749cd5da8 Dave Penkler 2024-09-18 806 MODULE_DEVICE_TABLE(pnp, hp_82341_pnp_table); > 6d4f8749cd5da8 Dave Penkler 2024-09-18 807 > The MODULE_DEVICE_TABLE macro does not really "use" the hp_82341_pnp_table variable. It just generates a mangled symbol with it but it also adds the unused attribute. However when compiled as a built-in the macro is a no-op and so the variable is flagged as unused. I think the unused pnp_device_id variables and their MODULE_DEVICE_TABLE declarations can safely be removed or bracketed by an #ifdef MODULE The same problem exists in drivers/staging/gpib/tnt4882/tnt4882_gpib.c and drivers/comedi/drivers/ni_atmio.c -dave