Aw: Re: [PATCH] mfd: syscon: Restore device_node_to_regmap() for non-syscon nodes

Frank Wunderlich
2025-02-03T13:16:58Z

regards Frank

> Gesendet: Sonntag, 2. Februar 2025 um 23:57
> Von: "Daniel Golle" <daniel@makrotopia.org>
> Betreff: Re: [PATCH] mfd: syscon: Restore device_node_to_regmap() for non-syscon nodes
>
> On Fri, Jan 24, 2025 at 01:16:44PM -0600, Rob Herring (Arm) wrote:
> > Commit ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a
> > "syscon" compatible") broke drivers which call device_node_to_regmap()
> > on nodes without a "syscon" compatible. Restore the prior behavior for
> > device_node_to_regmap().
> >
> > This also makes using device_node_to_regmap() incompatible with
> > of_syscon_register_regmap() again, so add kerneldoc for
> > device_node_to_regmap() and syscon_node_to_regmap() to make it clear
> > how and when each one should be used.
> >
> > Fixes: ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a "syscon" compatible")
> > Cc: Will McVicker <willmcvicker@google.com>
> > Cc: John Madieu <john.madieu.xa@bp.renesas.com>
> > Cc: Nishanth Menon <nm@ti.com>
> > Reported-by: Vaishnav Achath <vaishnav.a@ti.com>
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > ---
>
> Reviewed-by: Daniel Golle <daniel@makrotopia.org>
> Texted-by: Daniel Golle <daniel@makrotopia.org>

fixing Daniels Tested-by-tag :)
Tested-by: Daniel Golle <daniel@makrotopia.org>
and confirming the patch fixes the clock-syscon-issue (on mt7988)
Tested-by: Frank Wunderlich <frank-w@public-files.de>

> This fix is required to un-break various Mediatek clock drivers as
> device_node_to_regmap() is used all over the place there (in
> reset.c, clk-gate.c, clk-cpumux.c, clk-mux.c) and commit
> 3ba5a6159434 ("arm64: dts: mediatek: mt7622: fix clock controllers")
> has droped all those unneeded "syscon"s.