From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: mchehab@kernel.org, linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: mantis_ca_init - missing call???
Date: Mon, 27 Jan 2025 00:47:23 +0000 [thread overview]
Message-ID: <Z5bXm43f8BLLeCXy@gallifrey> (raw)
Hi,
My scripts noticed that the mantis_ca_init() and mantis_ca_exit()
functions aren't called anywhere; I was about to deadcode them, but
hmm, to me this looks more likely a bug, but I don't know
the code, so thought it best to ask.
mantis_ca_init() sets up a function pointer structure to a whole
bunch of static functions that can't be called; so that means the
whole of mantis_ca.c is dead.
commit b3b961448f70 ("V4L/DVB (13795): [Mantis/Hopper] Code overhaul, add Hopper
devices into the PCI ID list")
removed the only call to mantis_ca_init() in 2009.
Similarly, the last call to mantis_ca_exit() was removed at nearly the same time
by commit 0bdc799b8b82 ("V4L/DVB (13802): [Mantis/Hopper] Fix all build related warnings")
There is a commented out call to mantis_ca_exit() in mantis_dvb.c.
Thanks in advance,
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
reply other threads:[~2025-01-27 0:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5bXm43f8BLLeCXy@gallifrey \
--to=linux@treblig.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox