Re: [BUG,BISECTED] WARNING dcn20_find_secondary_pipe

[Imre Deak <imre.deak@intel.com>]

On Sun, Jan 26, 2025 at 04:46:49PM +0000, Chris Bainbridge wrote:
> Hardware is HP Pavilion Aero 13 laptop with Dell WD19 dock and three
> external monitors. I get a warning with recent kernel builds when
> enabling the external monitors with xrandr after initial boot:
> 
> 16:57:49 kernel: WARNING: CPU: 4 PID: 1347 at drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn20/dcn20_resource.c:1734 dcn20_find_secondary_pipe+0x1a6/0x400 [amdgpu]
>
> [...]
> 
> The bisect leads to a merge commit 43102a2012c2 ("Merge tag
> 'drm-misc-fixes-2024-09-26'"). Neither parent commit produces the
> warning, but the merged commit does.
> 
> There are two commits that interact to cause this warning:
> 
> 2a2a865aee43 ("drm/amd/display: Add all planes on CRTC to state for
> overlay cursor").
> 
> and
> 
> 70a6587dca37 ("drm/dp_mst: Fix DSC decompression detection in Synaptics
> branch devices")
> 
> 2a2a865aee43 was added to the mainline Linux repo first, but the warning
> only appears following the merge of 70a6587dca37.

The effect of 70a6587dca37 is to enable DSC only if the dock supports
this. IIRC the WD19 dock does support DSC in both of the branch devices
within it, so not sure how the commit makes a difference on it.

Checking if it's the DP_DSC_SUPPORT DPCD register AUX read which fails,
or if the DP_DSC_DECOMPRESSION_IS_SUPPORTED flag is not set in the
register would tell more (maybe by using drm.debug=0x100).

In any case not sure how the reported DSC capability would relate to
the above warn in dcn20_find_secondary_pipe(), the driver should handle
a dock both with and without DSC support.

> #regzbot introduced: 43102a2012c2