From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9B2FDF59 for ; Mon, 27 Jan 2025 18:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738003647; cv=none; b=n4YtrudN7oH8JLL+W/+/dz60AJo2ozsG8ta/JpkHRv0U7CxVdw4E+n+hQZbwvjv1tnUXd+TgbZRlpM0ukijwWY0iB25mpoOUt9CdIsmd4L0dcl/nqKiK58olsJC7ZDBYT7RytLzLcYEYGgF3E7ZYTKhvudj0zxLrfoJPL45ykwg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738003647; c=relaxed/simple; bh=Dt037qOPIxeSxHyVZI48Pt0KqJ9tzN8v0SVFSjpHwek=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AorY6pIsAoh9wsM6Ut4LVa05/Bdg/zuiJWsk26+2rxPTASvNOIa55PfU1Q6lD+9haGi+it+fclEBfJUfIO8OetQnkWkBsAYCFeUS1HFP7EanDZlLCBZ+6tDIbX1X/LsKjWcAU+XyUHdjDkl8JXdaGXXLw9wr7f7yYNenqOXDgWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=aBGlWlXg; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="aBGlWlXg" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-21644aca3a0so111026245ad.3 for ; Mon, 27 Jan 2025 10:47:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1738003645; x=1738608445; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bkSF+0ISeerq10paktOlHZQEYwsvQQQDuOj7ECb3/tI=; b=aBGlWlXgOPUZXEP/NMN8DqhDhmMZeGGJYL/sNHgAZskCAVo7VGw3qQD8CGHLnOLb1g TKcPy3eoLDZTDEJLbxlEV0CawZ7zRT7KYsDt+9fuearZ4Q0EPZ5/gBdVmbNIvtuhq36o gFBLNP5/efgOlgZSavCeu8NWBFwz9WPr4nv4i4u2IJG8t66T72TvdYlFlDGcWFhtdGTQ 3+wcwi/cZO+97qYLY8Rvcnh2BaWdCGsysGyO0NhfXzFt4oNt/ZnNnv/hoNX3xjUl4yeY o3K8Q/y4quxiyNGi53uf5+acADuE4w2UqQM0PLAfjJE/jaYgGv9uPt9ldUw7D8a+IQ30 VlHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738003645; x=1738608445; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bkSF+0ISeerq10paktOlHZQEYwsvQQQDuOj7ECb3/tI=; b=r/wA/6kdB8EiSYGHtvHn8DMVcGSwzZIHae5WDkKzKq/nDPgNI1VC3ZZliRg6QbPTFv M//TdD7E92RZlX7Oh6l9vW9RdWf7f9BepDvmQe9WbBSLyMe5HY0+8AoOhepf3ufBZJ9F XackFwRjqrPruGVR/QW6dJioIx1LNSp2LWhdT5MlKdLe9qecznv1WUsNZVQSwaEAw1u/ jqzXXvxEdSKVosBJM3Co6o95MYCS3ix5dRHU56hAoxxtiZymxvVYBmTIQaHfp1zgCNO4 fw9I27GnkpzdXeCdlFLa/7eWQN8QuizER4xmT99FLdzvsBXsDtsKU9QhJ5tAb5sINq6v 4MsQ== X-Forwarded-Encrypted: i=1; AJvYcCVNzQctZJMRhPTW6rzraa/XCiXrfdpH6IiiVl0HJNLdmcA1pDhGsPfuGyMxR+Yhhw1up4ZE+7myTvyffZ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx0wTDaEcZbpieOyHmMDAXhXQVEETeqPPKPvtCCYF+vqarXt6U CU28cW2p04a+2PrBNpLRY2xGMEUjJM/SpNLv4qMLOiAj15tGR4QFNaa4ZkVlW/M= X-Gm-Gg: ASbGncu8d9OBdsCnvLP2elXSal1Gv2Zs1AVf1wNvu/ePCG89VCuBJsBeCGcMFEtjRks ptTn5ckjIVNUpjwv9ooSVSuAGtFi3SD0+V30v8xlWaPIY88aBrXuEKOeG5E8LgmxA52um+pKPOQ wk0ww2JtB5KNUqRBDGj5lP7vj4QiNftLqWDbrccSzV9Av4UF3VaHUbiVEMjbnUh0q9lqgh7lwQt OR5s5izhC1OdumEPzuEX4oPj5XY71rwfpaLWE7/B4X8JtJpknZDxKB8z/RWfikJn3uqQH5gXKpE X-Google-Smtp-Source: AGHT+IF4DDDvvfyCwXwxozX8ipctJkmqqL71HB2zFupCiXgntkwLtEh01Sy+sLg23miQ5mHF9eG+tw== X-Received: by 2002:a05:6a00:21cd:b0:72d:3861:895c with SMTP id d2e1a72fcca58-72dafa030ebmr62134321b3a.8.1738003644966; Mon, 27 Jan 2025 10:47:24 -0800 (PST) Received: from ghost ([2601:647:6700:64d0:e3cf:e6bf:f7df:7ed2]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72f8a77f6f6sm7479122b3a.155.2025.01.27.10.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jan 2025 10:47:24 -0800 (PST) Date: Mon, 27 Jan 2025 10:47:21 -0800 From: Charlie Jenkins To: Ben Dooks Cc: Paul Walmsley , Palmer Dabbelt , Ard Biesheuvel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: Add runtime constant support Message-ID: References: <20250127-runtime_const_riscv-v1-1-795b023ea20b@rivosinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 27, 2025 at 08:51:04AM +0000, Ben Dooks wrote: > On 27/01/2025 08:18, Charlie Jenkins wrote: > > Implement the runtime constant infrastructure for riscv. Use this > > infrastructure to generate constants to be used by the d_hash() > > function. > > > > This is the riscv variant of commit 94a2bc0f611c ("arm64: add 'runtime > > constant' support") and commit e3c92e81711d ("runtime constants: add > > x86 architecture support"). > > > > Signed-off-by: Charlie Jenkins > > I think my only comment on this is we should treat instructions as > __le32 type and add the proper conversions when maniuplating them. Fair enough, I will make the proper adjustements. - Charlie > > -- > Ben Dooks http://www.codethink.co.uk/ > Senior Engineer Codethink - Providing Genius > > https://www.codethink.co.uk/privacy.html