From: Tejun Heo <tj@kernel.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
Yury Norov <yury.norov@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched_ext: Move built-in idle CPU selection policy to a separate file
Date: Mon, 27 Jan 2025 09:19:11 -1000 [thread overview]
Message-ID: <Z5fcL-e5Jf3yt53Y@slm.duckdns.org> (raw)
In-Reply-To: <20250125213911.283318-1-arighi@nvidia.com>
On Sat, Jan 25, 2025 at 10:39:11PM +0100, Andrea Righi wrote:
...
> @@ -7823,6 +7110,12 @@ static int __init scx_init(void)
> &scx_kfunc_set_unlocked)) ||
> (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_SYSCALL,
> &scx_kfunc_set_unlocked)) ||
> + (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_STRUCT_OPS,
> + &scx_kfunc_set_idle)) ||
> + (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_TRACING,
> + &scx_kfunc_set_idle)) ||
> + (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_SYSCALL,
> + &scx_kfunc_set_idle)) ||
Just one more change. Can you please make the set themselves static in
ext_idle.c and then register them from its own init function which is called
from scx_init()?
Thanks.
--
tejun
prev parent reply other threads:[~2025-01-27 19:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-25 21:39 [PATCH v2] sched_ext: Move built-in idle CPU selection policy to a separate file Andrea Righi
2025-01-27 19:19 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5fcL-e5Jf3yt53Y@slm.duckdns.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=void@manifault.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox