From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9F2F193436 for ; Mon, 27 Jan 2025 19:19:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738005552; cv=none; b=R5I/QKj6DzA/rAmb5/Oi3CP6QGsmjkJGqC5VzDwT8rLod+XSl48wWr2wQKH3vXL+Li5sxKHpFV7urcoI1K6tED6wd+w4yDKADNh3bscOkosBh8l6aDs87awZ4IZhQ94i0MxO+xFfN0Jwikexur/7vxQ0EOGwyDHtLE3lHm5nC8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738005552; c=relaxed/simple; bh=fC00zD7tyAe1r97FNHO0OJ7DFBzvffWzt2++UgS3EiQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hp9pOcxHZiXqcElwMu5RJqLfAfdWo/7jgJluz5Konc+LQFbobB9IqK/RcYm0YsrjqkbyNTadqpPKY94hZzXL0bqgTdlaJR7siPgvViZy/WFO7PzoehOpugYatKjU9ycEPD5MtF3teQcCM3HevzinzSC9Yxbz61IsC06+5xiZ0qM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VPANQWG4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VPANQWG4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DBD7C4CED2; Mon, 27 Jan 2025 19:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738005552; bh=fC00zD7tyAe1r97FNHO0OJ7DFBzvffWzt2++UgS3EiQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VPANQWG4hrX44mJtXBrGCU03tU/YkcgEIguw++KRtVq+BGkJcRAIipMdD0GAlc61j dL5yMZgL6wri9pJ1kd7hQUiu++w3jhqMCQLEiK7C4mDgFsf3r3se5Kdkow3hLxbCmE zs2Pw2reHc3h1W8ZmqQ8K67Wgfr0LIwMaHJO2ipdNuZezJbKlP2oGe3aCJm+GanpBR kA+uPBcA1uc0XmRtBZ6FzV88jAWzAemc2IohoWik3IiEC1c/IyD97JQAiXM4fnAbBI Y+BuludzTa59zT8NBmgDtW+o/Abey9YOPpODcxdectBphoaRIkxeFVJQ4AAkFOHlT4 J/cXzi7fUWKpA== Date: Mon, 27 Jan 2025 09:19:11 -1000 From: Tejun Heo To: Andrea Righi Cc: David Vernet , Changwoo Min , Yury Norov , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] sched_ext: Move built-in idle CPU selection policy to a separate file Message-ID: References: <20250125213911.283318-1-arighi@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250125213911.283318-1-arighi@nvidia.com> On Sat, Jan 25, 2025 at 10:39:11PM +0100, Andrea Righi wrote: ... > @@ -7823,6 +7110,12 @@ static int __init scx_init(void) > &scx_kfunc_set_unlocked)) || > (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_SYSCALL, > &scx_kfunc_set_unlocked)) || > + (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_STRUCT_OPS, > + &scx_kfunc_set_idle)) || > + (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_TRACING, > + &scx_kfunc_set_idle)) || > + (ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_SYSCALL, > + &scx_kfunc_set_idle)) || Just one more change. Can you please make the set themselves static in ext_idle.c and then register them from its own init function which is called from scx_init()? Thanks. -- tejun