Re: [PATCH v1 3/3] usb: dwc3: gadget: Skip endpoints ep[18]{in,out} on Intel Merrifield

Thinh Nguyen
2025-01-21T23:52:02Z

On Tue, Jan 21, 2025, Thinh Nguyen wrote:
> On Fri, Jan 17, 2025, Andy Shevchenko wrote:
> > On Thu, Jan 16, 2025 at 11:39:42PM +0000, Thinh Nguyen wrote:
> > > On Thu, Jan 16, 2025, Andy Shevchenko wrote:
> >
> > ...
> >
> > > > + * Intel Merrifield uses these endpoints for tracing and they shouldn't be used
> > > > + * for normal transfers, we need to skip them.
> > > > + * • 1 High BW Bulk IN (IN#1) (RTIT)
> > > > + * • 1 1KB BW Bulk IN (IN#8) + 1 1KB BW Bulk OUT (Run Control) (OUT#8)
> > >
> > > Please use regular bullet character and list the endpoint per line.
> >
> > Which is...?
> >
> > To my curiosity, what's wrong with the above?
> >
>
> Please use a character that we can find on the keyboard (- or * for
> example).
>
> And why would you want to list them like this:
>
> * Endpoint A
> * Endpoint B + Endpoint C
>
> As oppose to:
>
> * Endpoint A
> * Endpoint B
> * Endpoint C
>

Also, please fix the $subject and replace "endpoints ep[18]{in,out}" to
just "reserved endpoints".

BR,
Thinh