Re: [PATCH v1 3/3] usb: dwc3: gadget: Skip endpoints ep[18]{in,out} on Intel Merrifield

Andy Shevchenko
2025-01-22T16:24:03Z

On Tue, Jan 21, 2025 at 11:46:17PM +0000, Thinh Nguyen wrote:
> On Fri, Jan 17, 2025, Andy Shevchenko wrote:
> > On Thu, Jan 16, 2025 at 11:39:42PM +0000, Thinh Nguyen wrote:
> > > On Thu, Jan 16, 2025, Andy Shevchenko wrote:

...

> > > > + * Intel Merrifield uses these endpoints for tracing and they shouldn't be used
> > > > + * for normal transfers, we need to skip them.
> > > > + * • 1 High BW Bulk IN (IN#1) (RTIT)
> > > > + * • 1 1KB BW Bulk IN (IN#8) + 1 1KB BW Bulk OUT (Run Control) (OUT#8)
> > >
> > > Please use regular bullet character and list the endpoint per line.
> >
> > Which is...?
> >
> > To my curiosity, what's wrong with the above?
>
> Please use a character that we can find on the keyboard (- or * for
> example).

Hmm... We can find all characters on keyboard by using standard approach of
typing Unicode ones. I'm not sure why this is a problem. Linux kernel is UTF-8
ready project (from source tree point of view), at least I haven't found any
limitations in the documentation.

Note, this is _not_ a kernel-doc style to which you may refer when pointing out
to the how lists should be represented.

But it's not big deal for me to change the • character.

> And why would you want to list them like this:
>
> * Endpoint A
> * Endpoint B + Endpoint C

Because:
1) they are logically connected;
2) the above is the exact citation from the specification and I would like to
keep it that way.

> As oppose to:
>
> * Endpoint A
> * Endpoint B
> * Endpoint C

--
With Best Regards,
Andy Shevchenko