From: Uladzislau Rezki <urezki@gmail.com>
To: "Paul E . McKenney" <paulmck@kernel.org>
Cc: "Paul E . McKenney" <paulmck@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>, RCU <rcu@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Cheung Wall <zzqq0103.hey@gmail.com>,
Neeraj upadhyay <Neeraj.Upadhyay@amd.com>,
Joel Fernandes <joel@joelfernandes.org>,
Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>
Subject: Re: [PATCH 1/4] rcutorture: Allow a negative value for nfakewriters
Date: Tue, 28 Jan 2025 21:55:19 +0100 [thread overview]
Message-ID: <Z5lEN8WdvPyq7dRs@pc636> (raw)
In-Reply-To: <20250123185828.460836-1-urezki@gmail.com>
Hello, Paul!
> Currently "nfakewriters" parameter can be set to any value but
> there is no possibility to adjust it automatically based on how
> many CPUs a system has where a test is run on.
>
> To address this, if the "nfakewriters" is set to negative it will
> be adjusted to num_possible_cpus() during torture initialization.
>
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> ---
> kernel/rcu/rcutorture.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index d26fb1d33ed9..6bc161e1e8ac 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -4050,6 +4050,10 @@ rcu_torture_init(void)
> writer_task);
> if (torture_init_error(firsterr))
> goto unwind;
> +
> + if (nfakewriters < 0)
> + nfakewriters = (int) num_possible_cpus();
> +
> if (nfakewriters > 0) {
> fakewriter_tasks = kcalloc(nfakewriters,
> sizeof(fakewriter_tasks[0]),
> --
> 2.39.5
>
Don't you mind to take this as well? It is needed for:
rcu: Update TREE05.boot to test normal synchronize_rcu()
--
Uladzislau Rezki
next prev parent reply other threads:[~2025-01-28 20:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 18:58 [PATCH 1/4] rcutorture: Allow a negative value for nfakewriters Uladzislau Rezki (Sony)
2025-01-23 18:58 ` [PATCH 2/4] torture: Remove CONFIG_NR_CPUS configuration Uladzislau Rezki (Sony)
2025-01-23 20:29 ` Paul E. McKenney
2025-01-24 11:41 ` Uladzislau Rezki
2025-01-24 15:45 ` Paul E. McKenney
2025-01-24 17:21 ` Uladzislau Rezki
2025-01-24 17:36 ` Paul E. McKenney
2025-01-24 17:48 ` Uladzislau Rezki
2025-01-24 19:34 ` Paul E. McKenney
2025-01-27 13:27 ` Uladzislau Rezki
2025-01-27 14:51 ` Paul E. McKenney
2025-01-27 15:42 ` Uladzislau Rezki
2025-01-27 16:51 ` Paul E. McKenney
2025-01-27 17:26 ` Uladzislau Rezki
2025-01-27 18:15 ` Paul E. McKenney
2025-01-27 18:31 ` Uladzislau Rezki
2025-01-27 19:24 ` Uladzislau Rezki
2025-01-27 20:37 ` Uladzislau Rezki
2025-01-28 0:14 ` Paul E. McKenney
2025-01-28 12:17 ` Uladzislau Rezki
2025-01-28 12:41 ` Paul E. McKenney
2025-01-28 14:34 ` Uladzislau Rezki
2025-01-28 18:43 ` Paul E. McKenney
2025-01-28 20:57 ` Uladzislau Rezki
2025-01-23 18:58 ` [PATCH 3/4] rcu: Update TREE05.boot to test normal synchronize_rcu() Uladzislau Rezki (Sony)
2025-01-23 20:30 ` Paul E. McKenney
2025-01-23 18:58 ` [PATCH 4/4] rcu: Use _full() API to debug synchronize_rcu() Uladzislau Rezki (Sony)
2025-01-23 21:52 ` Paul E. McKenney
2025-01-24 11:48 ` Uladzislau Rezki
2025-01-24 15:49 ` Paul E. McKenney
2025-01-28 20:55 ` Uladzislau Rezki [this message]
2025-01-28 21:19 ` [PATCH 1/4] rcutorture: Allow a negative value for nfakewriters Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5lEN8WdvPyq7dRs@pc636 \
--to=urezki@gmail.com \
--cc=Neeraj.Upadhyay@amd.com \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksiy.avramchenko@sony.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=zzqq0103.hey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox