selftests/sched_ext: testing on BPF CI

selftests/sched_ext: testing on BPF CI

[Ihor Solodrai]

Hi Tejun, Andrea.

I tested a couple of variants of bpf-next + sched_ext source tree,
just sharing the results.

I found a working state: BPF CI pipeline ran successfully twice
(that's 8 build + run of selftests/sched_ext/runner in total).

Working state requires most patches between sched_ext/master and
sched_ext/for-6.14-fixes [1], and also the patch
  "tools/sched_ext: Receive updates from SCX repo" [2]

On plain bpf-next the dsp_local_on test fails [3].
Without the patch [2] there is a build error [4]: missing
SCX_ENUM_INIT definition.

We probably don't want to enable selftests/sched_ext on BPF CI with
that many "temporary" patches. I suggest to wait until all of this is
merged upstream.

You can check the full list of patches here:
https://github.com/kernel-patches/vmtest/pull/332/files

[1] https://git.kernel.org/pub/scm/linux/kernel/git/tj/sched_ext.git/log/?h=for-6.14-fixes
[2] https://lore.kernel.org/all/Z1ucTqJP8IeIXZql@slm.duckdns.org/
[3] https://github.com/kernel-patches/vmtest/actions/runs/13019837022
[4] https://github.com/kernel-patches/vmtest/actions/runs/13020458479

Re: selftests/sched_ext: testing on BPF CI

[Andrea Righi]

Hi Ihor,

On Wed, Jan 29, 2025 at 12:21:43AM +0000, Ihor Solodrai wrote:
> Hi Tejun, Andrea.
> 
> I tested a couple of variants of bpf-next + sched_ext source tree,
> just sharing the results.

Thanks for testing!

> 
> I found a working state: BPF CI pipeline ran successfully twice
> (that's 8 build + run of selftests/sched_ext/runner in total).

Ok.

> 
> Working state requires most patches between sched_ext/master and
> sched_ext/for-6.14-fixes [1], and also the patch
>   "tools/sched_ext: Receive updates from SCX repo" [2]
> 
> On plain bpf-next the dsp_local_on test fails [3].
> Without the patch [2] there is a build error [4]: missing
> SCX_ENUM_INIT definition.

We definitely need all the patches in sched_ext/for-6.14-fixes. I think
once Tejun sends the PR and we land the for-6.14-fixes upstream we should
reach a stable state with the sched_ext selftests. I don't have any other
additional pending fix at the moment.

> 
> We probably don't want to enable selftests/sched_ext on BPF CI with
> that many "temporary" patches. I suggest to wait until all of this is
> merged upstream.

Sounds reasonable to me. Tejun?

> 
> You can check the full list of patches here:
> https://github.com/kernel-patches/vmtest/pull/332/files
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/tj/sched_ext.git/log/?h=for-6.14-fixes
> [2] https://lore.kernel.org/all/Z1ucTqJP8IeIXZql@slm.duckdns.org/
> [3] https://github.com/kernel-patches/vmtest/actions/runs/13019837022
> [4] https://github.com/kernel-patches/vmtest/actions/runs/13020458479

Thanks,
-Andrea

Re: selftests/sched_ext: testing on BPF CI

[Tejun Heo]

On Wed, Jan 29, 2025 at 08:27:02AM +0100, Andrea Righi wrote:
> Hi Ihor,
> 
> On Wed, Jan 29, 2025 at 12:21:43AM +0000, Ihor Solodrai wrote:
> > Hi Tejun, Andrea.
> > 
> > I tested a couple of variants of bpf-next + sched_ext source tree,
> > just sharing the results.
> 
> Thanks for testing!
> 
> > 
> > I found a working state: BPF CI pipeline ran successfully twice
> > (that's 8 build + run of selftests/sched_ext/runner in total).
> 
> Ok.
> 
> > 
> > Working state requires most patches between sched_ext/master and
> > sched_ext/for-6.14-fixes [1], and also the patch
> >   "tools/sched_ext: Receive updates from SCX repo" [2]
> > 
> > On plain bpf-next the dsp_local_on test fails [3].
> > Without the patch [2] there is a build error [4]: missing
> > SCX_ENUM_INIT definition.
> 
> We definitely need all the patches in sched_ext/for-6.14-fixes. I think
> once Tejun sends the PR and we land the for-6.14-fixes upstream we should
> reach a stable state with the sched_ext selftests. I don't have any other
> additional pending fix at the moment.
> 
> > 
> > We probably don't want to enable selftests/sched_ext on BPF CI with
> > that many "temporary" patches. I suggest to wait until all of this is
> > merged upstream.
> 
> Sounds reasonable to me. Tejun?

Sure.

Thanks.

-- 
tejun

Re: selftests/sched_ext: testing on BPF CI

[Ihor Solodrai]

On 2025-01-28 4:21 p.m., Ihor Solodrai wrote:
> Hi Tejun, Andrea.
> 
> I tested a couple of variants of bpf-next + sched_ext source tree,
> just sharing the results.
> 
> I found a working state: BPF CI pipeline ran successfully twice
> (that's 8 build + run of selftests/sched_ext/runner in total).
> 
> Working state requires most patches between sched_ext/master and
> sched_ext/for-6.14-fixes [1], and also the patch
>    "tools/sched_ext: Receive updates from SCX repo" [2]
> 
> On plain bpf-next the dsp_local_on test fails [3].
> Without the patch [2] there is a build error [4]: missing
> SCX_ENUM_INIT definition.
> 
> We probably don't want to enable selftests/sched_ext on BPF CI with
> that many "temporary" patches. I suggest to wait until all of this is
> merged upstream.
> 

Hi everyone. I tried enabling sched_ext selftests on CI today, and there
are no issues on bpf-next tip (f263336a41da).

https://github.com/kernel-patches/vmtest/actions/runs/14802453691

If there are no objections, I'm going to push this to BPF CI on Monday.

As a reminder, this means that selftests/sched_ext test runner will be 
built and executed for pending BPF patches, and BPF CI pipeline will 
fail in case of problems there.

> You can check the full list of patches here:
> https://github.com/kernel-patches/vmtest/pull/332/files
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/tj/sched_ext.git/log/?h=for-6.14-fixes
> [2] https://lore.kernel.org/all/Z1ucTqJP8IeIXZql@slm.duckdns.org/
> [3] https://github.com/kernel-patches/vmtest/actions/runs/13019837022
> [4] https://github.com/kernel-patches/vmtest/actions/runs/13020458479

Re: selftests/sched_ext: testing on BPF CI

[Andrea Righi]

Hi Ihor,

On Fri, May 02, 2025 at 02:40:45PM -0700, Ihor Solodrai wrote:
> On 2025-01-28 4:21 p.m., Ihor Solodrai wrote:
> > Hi Tejun, Andrea.
> > 
> > I tested a couple of variants of bpf-next + sched_ext source tree,
> > just sharing the results.
> > 
> > I found a working state: BPF CI pipeline ran successfully twice
> > (that's 8 build + run of selftests/sched_ext/runner in total).
> > 
> > Working state requires most patches between sched_ext/master and
> > sched_ext/for-6.14-fixes [1], and also the patch
> >    "tools/sched_ext: Receive updates from SCX repo" [2]
> > 
> > On plain bpf-next the dsp_local_on test fails [3].
> > Without the patch [2] there is a build error [4]: missing
> > SCX_ENUM_INIT definition.
> > 
> > We probably don't want to enable selftests/sched_ext on BPF CI with
> > that many "temporary" patches. I suggest to wait until all of this is
> > merged upstream.
> > 
> 
> Hi everyone. I tried enabling sched_ext selftests on CI today, and there
> are no issues on bpf-next tip (f263336a41da).
> 
> https://github.com/kernel-patches/vmtest/actions/runs/14802453691
> 
> If there are no objections, I'm going to push this to BPF CI on Monday.
> 
> As a reminder, this means that selftests/sched_ext test runner will be built
> and executed for pending BPF patches, and BPF CI pipeline will fail in case
> of problems there.

I don't have any objection. The sched_ext selftests are in a stable state
now and I think it's a good idea to run them periodically against the
latest BPF patches to catch potential breakages early.

Thanks,
-Andrea

> 
> > You can check the full list of patches here:
> > https://github.com/kernel-patches/vmtest/pull/332/files
> > 
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/tj/sched_ext.git/log/?h=for-6.14-fixes
> > [2] https://lore.kernel.org/all/Z1ucTqJP8IeIXZql@slm.duckdns.org/
> > [3] https://github.com/kernel-patches/vmtest/actions/runs/13019837022
> > [4] https://github.com/kernel-patches/vmtest/actions/runs/13020458479
>