From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E23219AD8D for ; Thu, 30 Jan 2025 23:49:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738280974; cv=none; b=c2jLtxPR2uw3Vk4m/GpHya6ErfYJ97/at4efBfHgDyL/VgwuYdJh9nl3ckcLKhkNTkBb9daFN/JV7fmrqyDafldfBKDLXtNiq5n4W3tepTroqoRM8Uc6o4JR16riOl9wIsaCfchOj7b7/j/4aahCKkumFCG6bp3MzOwyVmA0IAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738280974; c=relaxed/simple; bh=TzE9p6vJK+kd/vqvGJmfvujwjKdd4YQm02mAUDjLSdM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Txp1v7awZeIHN78FxrpmXEtvqT0RcUuT8XFw9QT9/T6TqWM1Q2lrOq/+Kxmb2owSMyx2skatbWnWuDHsoGlQ6PaRZEEBi7et3tsY1lABDWdKWCd7scWtUYjVBZZSjeytMIJdnfKF2h3lHLZVnsRWwZXGMlltSL+aqJ08b2mwa8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SySEY6CO; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SySEY6CO" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2163affd184so23065ad.1 for ; Thu, 30 Jan 2025 15:49:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738280972; x=1738885772; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=woR0BNMl78Ng0EToVcH0CgI8K44IMNq5Bk4is7GN/hg=; b=SySEY6COjD4FqJI4tzAbiwElHcf5Xa6PKMgT+6P/AVvXsOrm3ADrThiPXgszAr70Vm e7EqqEIcdSwXwPooX9coOZeEsjaCw7nzcRHsyI5BAvvS3ccctZOSGRHijBjWVO1slvb6 z2DNalttMV3LlkDnQbOUvHaEzVchlDvQdFgq8Ta8plL0V5WLKDZjATzxhymy/8dYCEH/ /ISZSmf0LAKfbeE7CB2zh5oiGWUS9e3odulhE0GnzKrNvgsAWkjJG3T4aCyinbI6Xr1C qdG6UDdtD8+HvW1QlnBu7dCdPiX9azs/HCazdZry4IYoYg/TYU5OpH4xNa42GDzSfYs7 lQvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738280972; x=1738885772; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=woR0BNMl78Ng0EToVcH0CgI8K44IMNq5Bk4is7GN/hg=; b=OQu0go0GGpBebUx+MnZZiRtG4oWVSmKHd/DBWVljE0JYwdRQHQk4t27b4B6cqgGYVC LE2rnW+zs32ywBxCI8klqUO+LQ3nHmA1Q0Zs6SFj5fMyyI5hejf38GLhNoDccP/IYCCL T5kA4uAvD2Q0PR7FYVNqDcw3POoFBeD5y4BB5Q0tToK61AMqhgSG1E8Nn67h2JT8Cbai /NGArSX4R0iMcB7AAhZmRCCS91jzPyBbazPg+1GicdKvurJBcpJeWdNQcuwScQhy1gWE DHDgnXmlJDzW/+RTNvQeqssZcXRJXGpGuPmHLT1a+UORp+gc/MQQMINQIWQG+BdmNqCQ SefQ== X-Forwarded-Encrypted: i=1; AJvYcCVH57ssrF4p9IFp2dmWNy8NyiHRUMUGZ7iaGrKAPz1dd3/a6Sus80Y3rnT3CkypZbpZR4hjylfpUXjWBKw=@vger.kernel.org X-Gm-Message-State: AOJu0YxZjmNAbubhlC+UqwBVx8GpW25m5N9pQ4izgfako6HuPGDOyZwH ie1l5L4flzbQpCpRycw02klGZ+u4M5PklRqWAyjraze8V016IvSBSrv3G4/TCg== X-Gm-Gg: ASbGncuE1ZTGHRa8evxzCS2NmeHkUR/j3XMzDq97aw7yFWcds0swxov2/+l5x/czXMj 6Xh+7hZKjkx3C4iGGxfekwFCs0L3hntP9XS5NtIfmqATmb8UI6+SuXJDzIwMAHdl0ARQYXYXKOX N9O3kt/L5xLAfEOdvVZPyQ/x2mv7Uh9w/go4zAOzk6RSzEIrxGNiPnNpD1oPX/p9ErcKU/jhDi3 20ColJfgVaWY26JNZczWOzu91fEkwzXtpV91EtEsoVbvJwy0LjzFcmQJJrrrwL2oHeN238h5JO6 1x42Sc3HF5LRJ43XP4++JKDFint+ts6PS0PiuQGUcFYz8GwqHfc= X-Google-Smtp-Source: AGHT+IHOufC20z0nBQdOAecFf+23+39ZXOhYBxxAPbHAguO9mLeDxQV7tuiyPYnMVpf16VDWJ/sFyQ== X-Received: by 2002:a17:902:6908:b0:21d:dba1:dd72 with SMTP id d9443c01a7336-21edf044ffdmr405375ad.15.1738280972066; Thu, 30 Jan 2025 15:49:32 -0800 (PST) Received: from google.com (59.50.105.34.bc.googleusercontent.com. [34.105.50.59]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72fe631bfdasm2070744b3a.16.2025.01.30.15.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2025 15:49:31 -0800 (PST) Date: Thu, 30 Jan 2025 15:49:27 -0800 From: Igor Pylypiv To: Bart Van Assche Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Douglas Gilbert , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: core: Do not retry I/Os during depopulation Message-ID: References: <20250130222632.1462218-1-ipylypiv@google.com> <00557746-b7c6-4b34-ada7-0b4b8a21d98a@acm.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00557746-b7c6-4b34-ada7-0b4b8a21d98a@acm.org> On Thu, Jan 30, 2025 at 02:36:35PM -0800, Bart Van Assche wrote: > On 1/30/25 2:26 PM, Igor Pylypiv wrote: > > Fail I/Os instead of retry to prevent user space processes from being > > blocked on the I/O completion for several minutes. > > > > Retrying I/Os during "depopulation in progress" or "depopulation restore > > in progress" results in a continuous retry loop until the depopulation > > completes or until the I/O retry loop is aborted due to a timeout by > > the scsi_cmd_runtime_exceeced(). > > > > Depopulation is slow and can take 24+ hours to complete on 20+ TB HDDs. > > Most I/Os in the depopulation retry loop end up taking several minutes > > before returning the failure to user space. > > Since this patch is a bug fix, please add Fixes: and Cc: stable tags. Thank you, Bart. I'll add the following tags to v2: Cc: # 4.18.x: 2bbeb8d scsi: core: Handle depopulation and restoration in progress" Cc: # 4.18.x Fixes: e37c7d9a0341 ("scsi: core: sanitize++ in progress") Thanks, Igor > > Thanks, > > Bart.