Re: [PATCH 5/9] dt-bindings: dma: Convert fsl,elo*-dma bindings to YAML

J. Neuschäfer
2025-01-31T14:03:13Z

On Sun, Jan 26, 2025 at 10:47:35PM -0600, Rob Herring wrote:
> On Sun, Jan 26, 2025 at 07:59:00PM +0100, J. Neuschäfer wrote:
> > The devicetree bindings for Freescale DMA engines have so far existed as
> > a text file. This patch converts them to YAML, and specifies all the
> > compatible strings currently in use in arch/powerpc/boot/dts.
> >
> > Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> > ---
> > .../devicetree/bindings/dma/fsl,elo-dma.yaml | 129 +++++++++++++
> > .../devicetree/bindings/dma/fsl,elo3-dma.yaml | 105 +++++++++++
> > .../devicetree/bindings/dma/fsl,eloplus-dma.yaml | 120 ++++++++++++
> > .../devicetree/bindings/powerpc/fsl/dma.txt | 204 ---------------------
> > 4 files changed, 354 insertions(+), 204 deletions(-)
[...]
> > +patternProperties:
> > + "^dma-channel@.*$":
> > + type: object
>
> additionalProperties: false

I'll add it.

> (The tools should have highlighted this)

With dtschema 2024.11 installed, "make dt_binding_check
DT_SCHEMA_FILES=fsl,elo-dma.yaml" does not highlight this.

> > +
> > + properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - fsl,mpc8315-dma-channel
> > + - fsl,mpc8323-dma-channel
> > + - fsl,mpc8347-dma-channel
> > + - fsl,mpc8349-dma-channel
> > + - fsl,mpc8360-dma-channel
> > + - fsl,mpc8377-dma-channel
> > + - fsl,mpc8378-dma-channel
> > + - fsl,mpc8379-dma-channel
> > + - const: fsl,elo-dma-channel
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + cell-index:
> > + description: DMA channel index starts at 0.
> > +
> > + interrupts: true
>
> You have to define how many interrupts and what they are.

Will do.

(and the same for the other two files)

Best regards,
J. Neuschäfer