Re: [PATCH v2 06/10] i2c: kempld: Use i2c_10bit_addr_*_from_msg() helpers

Andy Shevchenko
2025-02-13T16:37:10Z

On Thu, Feb 13, 2025 at 05:15:09PM +0100, Wolfram Sang wrote:

...

> > /* Second part of 10 bit addressing */
> > if (i2c->state == STATE_ADDR10) {
> > - kempld_write8(pld, KEMPLD_I2C_DATA, i2c->msg->addr & 0xff);
> > + addr = i2c_10bit_addr_lo_from_msg(msg);
> > + i2c->state = STATE_START;
>
> Any reason you moved this?

Yes, I would like to be in sync in the above state machine case, just upper in
the code which is not visible in this patch.

> > + kempld_write8(pld, KEMPLD_I2C_DATA, addr);
>
> Maybe we could skip using 'addr' here?

Same reason as above.

> > kempld_write8(pld, KEMPLD_I2C_CMD, I2C_CMD_WRITE);
> >
> > - i2c->state = STATE_START;
> > return 0;
> > }

--
With Best Regards,
Andy Shevchenko