Re: [PATCH v1 2/2] spi: s3c64xx: add support exynos990-spi to new port config data

Tudor Ambarus
2025-02-13T07:10:58Z

On 2/12/25 7:12 PM, Denzeel Oliva wrote:
> +static const struct s3c64xx_spi_port_config exynos990_spi_port_config = {
> + /* fifo-depth must be specified in the device tree. */
> + .fifo_depth = 0,

have you tried testing without specifying the fifo_depth in DT?

You'll probably hit a divide by zero at:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/spi/spi-s3c64xx.c#n664

I assume the controller can work with 0 sized FIFO depth, and if so, the
driver has to be updated to allow 0 sized FIFOs.

btw, how did you test the set?