Re: [PATCH v1 1/1] pinctrl: : Switch to use for_each_gpiochip_node() helper

J. Neuschäfer
2025-02-18T14:21:02Z

On Thu, Feb 13, 2025 at 09:31:52PM +0200, Andy Shevchenko wrote:
> Switch the code to use for_each_gpiochip_node() helper.
>
> While at it, correct header inclusion as device property APIs
> are provided in property.h.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---

Looks good, thanks!

Reviewed-by: J. Neuschäfer <j.ne@posteo.net>

> drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> index cdad4ef11a2f..2f97accef837 100644
> --- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> +++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> @@ -10,7 +10,6 @@
> // block, shared between all GPIO banks
>
> #include <linux/device.h>
> -#include <linux/fwnode.h>
> #include <linux/gpio/driver.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> @@ -18,6 +17,7 @@
> #include <linux/module.h>
> #include <linux/mod_devicetable.h>
> #include <linux/platform_device.h>
> +#include <linux/property.h>
> #include <linux/regmap.h>
>
> #include <linux/pinctrl/pinconf.h>
> @@ -1033,7 +1033,7 @@ static int wpcm450_gpio_register(struct platform_device *pdev,
> return dev_err_probe(dev, PTR_ERR(pctrl->gpio_base),
> "Resource fail for GPIO controller\n");
>
> - device_for_each_child_node(dev, child) {
> + for_each_gpiochip_node(dev, child) {
> void __iomem *dat = NULL;
> void __iomem *set = NULL;
> void __iomem *dirout = NULL;
> @@ -1044,9 +1044,6 @@ static int wpcm450_gpio_register(struct platform_device *pdev,
> u32 reg;
> int i;
>
> - if (!fwnode_property_read_bool(child, "gpio-controller"))
> - continue;
> -
> ret = fwnode_property_read_u32(child, "reg", &reg);
> if (ret < 0)
> return ret;
> --
> 2.45.1.3035.g276e886db78b
>