From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD55E1FC114; Mon, 3 Feb 2025 08:43:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738572201; cv=none; b=t3miJMqt+W5kQPzM4tiPJvwFr1H8HhtLm9QIBvlPjUwUPqfEpaTBKJjVWLOm6UWCJrhlaLwB1jnQWcFP0tDyTx3NSebScB03cF0IqaTMlXDF29JeOtnItjZNsyTbwdWwRiDgk340i0JpWvTlz0DVZH2dTNFT9tdJcQep6elR/Us= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738572201; c=relaxed/simple; bh=FwAUacQljcRZFF1xn1SPGI9pnq7pl2aJpEklQbzKrpo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lc6tv1HbdoZoTvzuAXgy3qxCKIbSxVcBP6HhBHTF7mUY4R8M+gofcULgEiKUNChqBTBV7wq7BqeA0Q8waocePsq5JjmDF+WUAEvt4MxZcOIfvP1GZbWLtQitFtC+9cDAPKFSlewjmByqCZ7nUfNkNWvVsjkvSpCIIu6OYXOCQ60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W0cLxay6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W0cLxay6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35F56C4CED2; Mon, 3 Feb 2025 08:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738572201; bh=FwAUacQljcRZFF1xn1SPGI9pnq7pl2aJpEklQbzKrpo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W0cLxay68+wcUcOaB5u70pr54xWiiBRliaGDFPenjvefwsxm4WejrQS60RvrSgunQ x5zv2KiOMPjiahxLsnkif7BbPuWnEN3CThF2crQOxjEffEq/rqthvZMi2H13SiZX6r il+uujWR8DYTJaucNXxZTMfMMX0nW9RbN4liywSx0BMmjrFFyB4JY4SezEZxTH1rl3 FlZHQKhAJXRqzLwxlAP2/jcKY1qRPk7MxGOfv5DQSAn1R53CeYI4UPA9avojfe86w9 B2rN6pG2+kVgq7F3TDPviDA7l2DzOR0+rYL1wScr3mD2c1xRf0IUFDubB8GjJLFop9 sCsFUdT5jIudw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1tes3A-000000006dj-32tz; Mon, 03 Feb 2025 09:43:24 +0100 Date: Mon, 3 Feb 2025 09:43:24 +0100 From: Johan Hovold To: Stefan Schmidt Cc: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Hans Verkuil , Sebastian Fricke , Bryan O'Donoghue , Dmitry Baryshkov , Neil Armstrong , Nicolas Dufresne , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Jianhua Lu , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Vedang Nagar , Bjorn Andersson Subject: Re: [PATCH v9 00/28] Qualcomm iris video decoder driver Message-ID: References: <20241212-qcom-video-iris-v9-0-e8c2c6bd4041@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 22, 2025 at 04:34:51PM +0100, Stefan Schmidt wrote: > On Thu, 9 Jan 2025 at 15:58, Johan Hovold wrote: > > On Thu, Dec 12, 2024 at 05:21:22PM +0530, Dikshita Agarwal wrote: > > > Introduce support for Qualcomm new video acceleration hardware i.e. > > > iris, used for video stream decoding. > > > > > Note: A harmless onetime error log "Lucid PLL latch failed. Output may > > > be unstable!" is seen during bootup. It doesn't impact any video > > > usecase and is currently under discussion. > > > > This could be an indication that some resources are not described > > correctly and could potentially require both binding and driver changes > > to address. > > > > This is also something which could cause trouble later (e.g. during > > suspend) even if you manage to get the clock running after boot. > > > > Generally, you should not be introducing any new warnings; they are > > there to let you know that something is wrong. > > > > Where is this issue being discussed? > > > > I think we at least need a public analysis and understanding of the > > problem before merging this. > > Taniya Das proposed a patchset to reconfigure PLL in the clk-alpha-pll > which allows the videocc-sm8550 driver to configure it correctly. > https://lore.kernel.org/linux-arm-msm/20250113-support-pll-reconfigure-v1-0-1fae6bc1062d@quicinc.com/T/ > > I tested the Iris driver with this patchset and I am no longer seeing > the Lucid PLL latch failed warning. Thanks for the pointer. Please make sure to reference this series (and summarise the underlying issue) when resending this series. Judging from a quick look the approach taken there seems like a bit of a hack so it may not get merged in its current form. IIUC fixing the PLL issue properly may depend on adding support for multiple power domains to the clock drivers. Johan