Re: [PATCH v3 12/20] regulator: cros-ec: use devm_kmemdup_array()

Andy Shevchenko
2025-02-03T09:51:17Z

On Mon, Feb 03, 2025 at 01:38:54PM +0530, Raag Jadav wrote:
> Convert to use devm_kmemdup_array() which is more robust.

...

> data->voltages_mV =
> - devm_kmemdup(dev, resp.voltages_mv,
> - sizeof(u16) * data->num_voltages, GFP_KERNEL);
> + devm_kmemdup_array(dev, resp.voltages_mv, data->num_voltages,
> + sizeof(u16), GFP_KERNEL);

Wondering if this can be sizeof(*data->voltages_mV) that makes code robust
against type changes.

--
With Best Regards,
Andy Shevchenko