Re: [PATCH v3 02/20] iio: imu: st_lsm9ds0: Replace device.h with what is needed

Jonathan Cameron
2025-02-03T11:19:53Z

On Mon, 3 Feb 2025 13:38:44 +0530
Raag Jadav <raag.jadav@intel.com> wrote:

> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Instead of including a huge device.h with tons of dependencies
> include only what driver actually uses.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
I'm fine with these going whatever route makes sense.

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
> drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c | 2 +-
> drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c
> index 0732cfa258c4..8cc071463249 100644
> --- a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c
> +++ b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c
> @@ -7,7 +7,7 @@
> * Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> */
>
> -#include <linux/device.h>
> +#include <linux/device/devres.h>
> #include <linux/err.h>
> #include <linux/gfp_types.h>
> #include <linux/i2c.h>
> diff --git a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c
> index 43ec57c1e604..806e55f75f65 100644
> --- a/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c
> +++ b/drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c
> @@ -7,7 +7,7 @@
> * Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> */
>
> -#include <linux/device.h>
> +#include <linux/device/devres.h>
> #include <linux/err.h>
> #include <linux/gfp_types.h>
> #include <linux/module.h>