Re: [PATCH v3 01/20] driver core: Split devres APIs to device/devres.h

Raag Jadav
2025-02-06T18:11:16Z

On Thu, Feb 06, 2025 at 05:14:05PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 06, 2025 at 05:12:49PM +0200, Andy Shevchenko wrote:
> > On Thu, Feb 06, 2025 at 08:13:12AM +0200, Raag Jadav wrote:
> > > On Thu, Feb 06, 2025 at 12:27:03AM +0800, kernel test robot wrote:
>
> ...
>
> > > > 102
> > > > 103 static inline
> > > > 104 void __iomem *devm_ioremap_resource(struct device *dev, const struct resource *res)
> > > > 105 {
> > > > > 106 return ERR_PTR(-EINVAL);
> > > > 107 }
> > > > 108
> > >
> > > Andy, are we expecting this?
> >
> > Oh, no, it's sparse error, but easy to fix. Need to have
> >
> > return IOMEM_ERR_PTR(-EINVAL);
>
> But isn't it the original issue? I mean that it was already before this series.

For all this time?

> If so, perhaps you can fix all sparse errors like this in the devres* code.

With a fixes tag?

Raag