Re: [PATCH 2/3] KVM: x86: Remove use of apicv_update_lock when toggling guest debug state

Naveen N Rao
2025-02-04T13:15:54Z

On Mon, Feb 03, 2025 at 09:00:05PM -0500, Maxim Levitsky wrote:
> On Mon, 2025-02-03 at 22:33 +0530, Naveen N Rao (AMD) wrote:
> > apicv_update_lock is not required when querying the state of guest
> > debug in all the vcpus. Remove usage of the same, and switch to
> > kvm_set_or_clear_apicv_inhibit() helper to simplify the code.
>
> It might be worth to mention that the reason why the lock is not needed,
> is because kvm_vcpu_ioctl from which this function is called takes 'vcpu->mutex'
> and thus concurrent execution of this function is not really possible.
>
> Besides this:
>
> Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>

Sure, thanks for the review!

- Naveen