Re: [PATCH 5/9] dt-bindings: dma: Convert fsl,elo*-dma bindings to YAML

Rob Herring
2025-01-31T22:16:20Z

On Fri, Jan 31, 2025 at 8:03 AM J. Neuschäfer <j.ne@posteo.net> wrote:
>
> On Sun, Jan 26, 2025 at 10:47:35PM -0600, Rob Herring wrote:
> > On Sun, Jan 26, 2025 at 07:59:00PM +0100, J. Neuschäfer wrote:
> > > The devicetree bindings for Freescale DMA engines have so far existed as
> > > a text file. This patch converts them to YAML, and specifies all the
> > > compatible strings currently in use in arch/powerpc/boot/dts.
> > >
> > > Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> > > ---
> > > .../devicetree/bindings/dma/fsl,elo-dma.yaml | 129 +++++++++++++
> > > .../devicetree/bindings/dma/fsl,elo3-dma.yaml | 105 +++++++++++
> > > .../devicetree/bindings/dma/fsl,eloplus-dma.yaml | 120 ++++++++++++
> > > .../devicetree/bindings/powerpc/fsl/dma.txt | 204 ---------------------
> > > 4 files changed, 354 insertions(+), 204 deletions(-)
> [...]
> > > +patternProperties:
> > > + "^dma-channel@.*$":
> > > + type: object
> >
> > additionalProperties: false
>
> I'll add it.
>
> > (The tools should have highlighted this)
>
> With dtschema 2024.11 installed, "make dt_binding_check
> DT_SCHEMA_FILES=fsl,elo-dma.yaml" does not highlight this.

Actually, it's the top-level 'addtionalProperties: true' that disables
the check here. That should be false as well.

Rob