Re: [PATCH 6/9] dt-bindings: pci: Add fsl,mpc83xx-pcie bindings

J. Neuschäfer
2025-02-04T23:31:07Z

On Sun, Jan 26, 2025 at 10:50:04PM -0600, Rob Herring wrote:
> On Sun, Jan 26, 2025 at 07:59:01PM +0100, J. Neuschäfer wrote:
> > Supplement Documentation/devicetree/bindings/pci/fsl,pci.txt with a more
> > formal binding in YAML format.
> >
> > Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> > ---
[...]
> > +title: Freescale MPC83xx PCI/PCI-X/PCIe controllers
> > +
> > +description: |
> > + Binding for the PCI/PCI-X/PCIe host bridges on MPC8xxx SoCs.
> > + See also: Documentation/devicetree/bindings/pci/fsl,pci.txt
>
> Can you move that information here.

Will do.

>
> > +
> > +maintainers:
> > + - J. Neuschäfer <j.neuschaefer@gmx.net>
> > +
> > +allOf:
> > + - $ref: /schemas/pci/pci-host-bridge.yaml#
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - fsl,mpc8308-pcie
> > + - fsl,mpc8315-pcie
> > + - fsl,mpc8377-pcie
> > + - fsl,mpc8378-pcie
> > + - const: fsl,mpc8314-pcie
> > + - const: fsl,mpc8314-pcie
> > + - items:
> > + - const: fsl,mpc8360-pci
> > + - const: fsl,mpc8349-pci
> > + - const: fsl,mpc8349-pci
> > + - items:
> > + - const: fsl,mpc8540-pcix
> > + - const: fsl,mpc8540-pci
> > + - const: fsl,mpc8540-pci
> > + - items:
> > + - const: fsl,mpc8540-pcix
> > + - const: fsl,mpc8540-pci
> > + - const: fsl,mpc8548-pcie
> > + - const: fsl,mpc8548-pcie
> > + - const: fsl,mpc8641-pcie
>
> Move all the single 'const' to 1 enum entry.

Will do

> > +
> > + reg:
> > + minItems: 1
> > + items:
> > + - description: internal registers
> > + - description: config space access registers
> > +
> > + clock-frequency:
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
> Don't need a type for this.

Will change.

Thanks,
J. Neuschäfer