Re: [PATCH 0/2] tools: Unify top-level quiet infrastructure

Alexei Starovoitov
2025-02-04T23:02:55Z

On Tue, Feb 4, 2025 at 7:04 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Hello,
>
> On Tue, Feb 04, 2025 at 10:34:41AM -0800, Charlie Jenkins wrote:
> > On Tue, Feb 04, 2025 at 05:18:42PM +0000, Alexei Starovoitov wrote:
> > > On Tue, Feb 4, 2025 at 12:10 AM Charlie Jenkins <charlie@rivosinc.com> wrote:
> > > >
> > > > The quiet infrastructure was moved out of Makefile.build to accomidate
> > > > the new syscall table generation scripts in perf. Syscall table
> > > > generation wanted to also be able to be quiet, so instead of again
> > > > copying the code to set the quiet variables, the code was moved into
> > > > Makefile.perf to be used globally. This was not the right solution. It
> > > > should have been moved even further upwards in the call chain.
> > > > Makefile.include is imported in many files so this seems like a proper
> > > > place to put it.
> > > >
> > > > To:
> > > >
> > > > Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> > > > ---
> > > > Charlie Jenkins (2):
> > > > tools: Unify top-level quiet infrastructure
> > > > tools: Remove redundant quiet setup
> > > >
> > > > tools/arch/arm64/tools/Makefile | 6 -----
> > > > tools/bpf/Makefile | 6 -----
> > > > tools/bpf/bpftool/Documentation/Makefile | 6 -----
> > > > tools/bpf/bpftool/Makefile | 6 -----
> > > > tools/bpf/resolve_btfids/Makefile | 2 --
> > > > tools/bpf/runqslower/Makefile | 5 +---
> > > > tools/build/Makefile | 8 +-----
> > > > tools/lib/bpf/Makefile | 13 ----------
> > >
> > > Nack.
> > > libbpf and bpftool are synced independently to github
> > > and released from there.
> > > This change breaks it.
>
> Sorry, I overlooked this part and merged a change that touched the
> common files into the perf tree.
>
> f2868b1a66d4f40f ("perf tools: Expose quiet/verbose variables in Makefile.perf")
>
> Unfortunately, it's already in v6.14-rc1.
>
> >
> > Can you explain how it breaks it? Currently bpftool and resolve_btfids
> > don't build quietly so this was an attempt to fix that.
>
> So I think you will need something like this for v6.14. Again, sorry
> about the trouble.

Just revert f2868b1a66d4f40f that created this mess.