From: Frederic Weisbecker <frederic@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] kthreads fixes for v6.14-rc2
Date: Tue, 4 Feb 2025 22:39:54 +0100 [thread overview]
Message-ID: <Z6KJKul1JUIpHl0O@pavilion.home> (raw)
In-Reply-To: <CAHk-=wiPQ8PTWZuWXw8s+OLNmgXSM3+DxmY=uKd4F-Nnu4TB9A@mail.gmail.com>
Le Tue, Feb 04, 2025 at 11:06:57AM -0800, Linus Torvalds a écrit :
> On Tue, 4 Feb 2025 at 10:58, Frederic Weisbecker <frederic@kernel.org> wrote:
> >
> > - Properly handle return value when allocation fails for the preferred
> > affinity.
>
> Well, we have exactly one caller of this function, and that caller
> doesn't actually care about the return value.
>
> The function is literally the "preferred" affinity. If the affinity
> setup fails, it's harmless.
>
> Anyway, the fix doesn't look wrong, and I've pulled it, but it's just
> all very harmless. I think the "set but not used" error could have
> been fixed by just removing the 'ret' variable entirely.
Right, I wanted to be able to reflect failure just in case but the
point of doing it is certainly debatable... Thanks for pulling it
anyway!
next prev parent reply other threads:[~2025-02-04 21:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 18:58 [GIT PULL] kthreads fixes for v6.14-rc2 Frederic Weisbecker
2025-02-04 19:06 ` Linus Torvalds
2025-02-04 21:39 ` Frederic Weisbecker [this message]
2025-02-05 5:01 ` Dhruva Gole
2025-02-04 19:13 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6KJKul1JUIpHl0O@pavilion.home \
--to=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox