public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: Dhruva Gole <d-gole@ti.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Vlastimil Babka <vbabka@suse.cz>, Chen Yu <yu.c.chen@intel.com>,
	linux-kernel@vger.kernel.org, Kees Cook <kees@kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH V2] kthread: Fix build warning variable 'ret' set but not used
Date: Wed, 5 Feb 2025 12:09:04 +0100	[thread overview]
Message-ID: <Z6NG0HXhjAvDSWO_@localhost.localdomain> (raw)
In-Reply-To: <20250205061740.v7njfbfdx5ym4m7h@lcpd911>

Le Wed, Feb 05, 2025 at 11:47:40AM +0530, Dhruva Gole a écrit :
> On Feb 04, 2025 at 20:02:19 +0100, Frederic Weisbecker wrote:
> > Hi Dhruva,
> > 
> > Le Tue, Feb 04, 2025 at 09:39:21PM +0530, Dhruva Gole a écrit :
> > > Fix the following build time warning in kthread:
> > > 
> > >    kernel/kthread.c: In function 'kthread_affine_preferred':
> > > >> kernel/kthread.c:861:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
> > >      861 |         int ret;
> > >          |             ^~~
> > > 
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202501301528.t0cZVbnq-lkp@intel.com/
> > > Signed-off-by: Dhruva Gole <d-gole@ti.com>
> > 
> > Thanks for your patch but another similar fix was already pending. I have sent
> > the pull request there:
> > 
> > https://lore.kernel.org/lkml/Z6JjZMdbDoAX_AVW@pavilion.home/T/#u
> 
> OK, btw another qn I had was does this file not need a MAINTAINERS file
> update?
> I don't see a real MAINTAINER against it, everyone just shows as
> contributors / committers...
> Or is it to be sent to Linus directly?

There is no official maintainer for kthreads. But I volunteer to handle the patches
targeted to it at least for a while given my recent invasive changes there.

Thanks.

> 
> -- 
> Best regards,
> Dhruva Gole
> Texas Instruments Incorporated

      reply	other threads:[~2025-02-05 11:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30  7:16 kernel/kthread.c:861:13: warning: variable 'ret' set but not used kernel test robot
2025-02-04  9:08 ` [PATCH] kthread: Fix build warning " Dhruva Gole
2025-02-04 15:15   ` Kees Cook
2025-02-04 15:50     ` Dhruva Gole
2025-02-04 16:09   ` [PATCH V2] " Dhruva Gole
2025-02-04 19:02     ` Frederic Weisbecker
2025-02-05  6:17       ` Dhruva Gole
2025-02-05 11:09         ` Frederic Weisbecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6NG0HXhjAvDSWO_@localhost.localdomain \
    --to=frederic@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=d-gole@ti.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=vbabka@suse.cz \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox