public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: max98095: Remove unused max98095_jack_detect
Date: Wed, 5 Feb 2025 12:38:07 +0000	[thread overview]
Message-ID: <Z6Nbr4XIN421orTF@gallifrey> (raw)
In-Reply-To: <dc0bc826-6105-49f1-8a59-bb4881e9143e@sirena.org.uk>

* Mark Brown (broonie@kernel.org) wrote:
> On Wed, Feb 05, 2025 at 01:44:58AM +0000, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > max98095_jack_detect() was added in 2012 as part of
> > commit 9dd90c5db040 ("ASoC: max98095: add jack detection")
> > but hasn't been used.
> > 
> > Remove it.
> 
> > -	max98095_report_jack(client->irq, component);
> > -	return 0;
> > -}
> > -EXPORT_SYMBOL_GPL(max98095_jack_detect);
> 
> No, this is exported for machine drivers which might not be in tree.

Ah OK; of course it would be nice if they were in the tree.

Thanks,

Dave
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

  reply	other threads:[~2025-02-05 12:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-05  1:44 [PATCH] ASoC: max98095: Remove unused max98095_jack_detect linux
2025-02-05 12:21 ` Mark Brown
2025-02-05 12:38   ` Dr. David Alan Gilbert [this message]
2025-02-05 23:58     ` Dr. David Alan Gilbert
2025-02-06  0:15       ` Mark Brown
2025-02-06  0:18         ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6Nbr4XIN421orTF@gallifrey \
    --to=linux@treblig.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox