Re: [PATCH] ASoC: max98095: Remove unused max98095_jack_detect

Dr. David Alan Gilbert
2025-02-05T23:58:07Z

* Dr. David Alan Gilbert (linux@treblig.org) wrote:
> * Mark Brown (broonie@kernel.org) wrote:
> > On Wed, Feb 05, 2025 at 01:44:58AM +0000, linux@treblig.org wrote:
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > >
> > > max98095_jack_detect() was added in 2012 as part of
> > > commit 9dd90c5db040 ("ASoC: max98095: add jack detection")
> > > but hasn't been used.
> > >
> > > Remove it.
> >
> > > - max98095_report_jack(client->irq, component);
> > > - return 0;
> > > -}
> > > -EXPORT_SYMBOL_GPL(max98095_jack_detect);
> >
> > No, this is exported for machine drivers which might not be in tree.
>
> Ah OK; of course it would be nice if they were in the tree.

Mark:
Is that also true of mt6359_accdet_enable_jack_detect ?
I can't find any callers in tree.

Dave

> Thanks,
>
> Dave
> --
> -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> \ dave @ treblig.org | | In Hex /
> \ _________________________|_____ http://www.treblig.org |_______/