From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8041C1FFC4B; Wed, 5 Feb 2025 21:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738792404; cv=none; b=S4alCHiUJT9mL9pi2CfPPhSAOTS5MPloMQEHNODxeyonkdNrm37ohgcIK5ABgt+JRfjRIcVIxpMzG9zzhAbqz4qO3MRtjQ/nM4F4LzfxN/XAa4DYbYiBdsoTasGBOSd9ixt9JdRiPbXFKYMN5tvC6wqRrgBs9Ds+ANomW58QKkg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738792404; c=relaxed/simple; bh=x9d9cNYBFtlNcU52LjDGoQ5l6Zp8mlPVT0eIwPFJNkE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WqnAXAlfKmpoRtQEU2NP33xdwtMZQnd4XeKSqKkH19NUO0tyAxst1K+LHz2/Gs/nBakGLHYgDFzthaRrc2GnHnEnd09MWEzy943TnFtWzDjG2C7zc0otc4o/i+oBLlUG6vTUupIrqn90+Io4Os8DZvinZ3H2ZD/hafIsBRDB7zQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ddpq3QPo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ddpq3QPo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D637C4CED1; Wed, 5 Feb 2025 21:53:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738792403; bh=x9d9cNYBFtlNcU52LjDGoQ5l6Zp8mlPVT0eIwPFJNkE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ddpq3QPoxqKqJXu4nbOoGVAshaVJZnbKEirnXkeMKhNKHOhpp9xowG3WQ3X3yey/R 55llMKdNRN6CX1Fl2+1wXM+P93kTa1ekSaskdQ7/KJTDPIjxQzg/0GNloe0K00SMK2 wiaAnv2+nRHSSrguab5790uJ5TQ7ggsKIH0UcFk5egkbQIN0FtANdXTc0jqyGVIUQ3 9z/g42e7anHkT/nB6bjILT/tUH/CticoDTSO9SPfaW5qfdZAqOph4RJmlcpmng+0ax KORxvwKv6SMCPBYV8rSA1N+JW65mbAnJQwOJGRCt+9o6OOSyVIdLBcB2rO9RuKrS/r JO1BaxUGXUoBw== Date: Wed, 5 Feb 2025 16:53:22 -0500 From: Sasha Levin To: Namhyung Kim Cc: Ian Rogers , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , Alexander Shishkin , Andi Kleen , Athira Rajeev , Ben Gainey , Colin Ian King , Dominique Martinet , Ilkka Koskinen , Ingo Molnar , James Clark , Jiri Olsa , Kan Liang , Mark Rutland , Oliver Upton , Paran Lee , Peter Zijlstra , "Steinar H . Gunderson" , Steven Rostedt , Thomas Falcon , Weilin Wang , Yang Jihong , Yang Li , Ze Gao , Zixian Cai , zhaimingbing Subject: Re: [PATCH AUTOSEL 6.13 06/16] tool api fs: Correctly encode errno for read/write open failures Message-ID: References: <20250126150720.961959-1-sashal@kernel.org> <20250126150720.961959-6-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Jan 26, 2025 at 12:41:31PM -0800, Namhyung Kim wrote: >Hello, > >On Sun, Jan 26, 2025 at 10:27 AM Ian Rogers wrote: >> >> On Sun, Jan 26, 2025 at 7:07 AM Sasha Levin wrote: >> > >> > From: Ian Rogers >> > >> > [ Upstream commit 05be17eed774aaf56f6b1e12714325ca3a266c04 ] >> > >> > Switch from returning -1 to -errno so that callers can determine types >> > of failure. >> >> Hi Sasha, >> >> This change requires changes in the perf tool. The issue is the -1 >> gets written to perf.data files in the topology, the -errno value is >> "corrupt." Because of this, I'd suggest not backporting this change. > >Agreed. Please remove this patch from the all stable series. I'll drop it, thanks! -- Thanks, Sasha