Re: [PATCH v3 3/3] KVM: x86: Document host suspend being included in steal time.

Sean Christopherson
2025-01-07T15:37:56Z

On Tue, Jan 07, 2025, Suleiman Souhlal wrote:
> Steal time now includes the time that the host was suspended.
>
> Change-Id: Ie1236bc787e0d3bc9aff0d35e6b82b7e5cc8fd91

gerrit.

> Signed-off-by: Suleiman Souhlal <suleiman@google.com>
> ---
> Documentation/virt/kvm/x86/msr.rst | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/virt/kvm/x86/msr.rst b/Documentation/virt/kvm/x86/msr.rst
> index 3aecf2a70e7b43..81c17c2200ca2f 100644
> --- a/Documentation/virt/kvm/x86/msr.rst
> +++ b/Documentation/virt/kvm/x86/msr.rst
> @@ -294,8 +294,10 @@ data:
>
> steal:
> the amount of time in which this vCPU did not run, in
> - nanoseconds. Time during which the vcpu is idle, will not be
> - reported as steal time.
> + nanoseconds. This includes the time during which the host is
> + suspended. However, the case where the host suspends during a
> + VM migration might not be correctly accounted. Time during
> + which the vcpu is idle, will not be reported as steal time.

This belongs in the previous patch. All in all, IMO this can all be one single
patch, as I don't see any reason to put crud into common KVM.

>
> preempted:
> indicate the vCPU who owns this struct is running or
> --
> 2.47.1.613.gc27f4b7a9f-goog
>