From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DB821EA7C6 for ; Thu, 6 Feb 2025 13:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738850366; cv=none; b=kxJtYDHHNQ8Vd8g4Hgg4ItPYUE+mnRApz6cMcl3NrHwbBC3I3y+YtiZpVu5viMi5+ZkDcABc31oRoh0xZpZ4ob+QxOsqtcu4+GDBg38HPDs+wSBCb5NLHLbrdOPFzl+Z+Qd5mpJdpuLR8RT4ZdhWix6T4GbMCAIz7/9mCv/W4o4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738850366; c=relaxed/simple; bh=5fteU1gF781gid+8eh5MjlcPKwLt80L36gWbaB+12iI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j6Iu0KUSx9+DueE0rvXAFhsNo4p6Ch9o0T2nQ5R7pWkxBeNs2+k6vTSWhchwJvKRgtF0uOOkkodmNcjpuM1KN5NVDQFHk1sVy54+BLYVTGZakq1rksekhnvjfRinXrTES82gNF2EES3Dte8gpXC2Ninn3K7+v0ZJ3SIWHqdrA4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OatzRcim; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OatzRcim" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-436345cc17bso6762285e9.0 for ; Thu, 06 Feb 2025 05:59:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738850363; x=1739455163; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yiwqOK4FVjPPZWydFoWK7z8lcOGoGBb2vdMSdzrBdU8=; b=OatzRcimDGdLls//YoBjw+3AT/P3yBXg7j2nABbUhb30Ny3IIz4uvLLrJlAXxgygnY z7Ubvhwe4C7+G9jvIONILzFbZolANH3Y5Q5EVzs8qjngkq0eh5NUrEP2oY3SrBC0QBgd Ew5jqfHp6fHDS/oiXdjVdeYYOh4fnIwInMSrmaSM9PIwMSTYD7XyB3FC+LSnzgVkkD7f HL5SVa2N3UKZNT8cSD/g8RN40OMJK9sJD2B5lLgBGjjWTjyNTvFHUmuZV/6GuEP8/Mip cbVf3v8BZ3ZYOgac8af/oWZytR/seG0REYDeFMGgVe1ICBN8BjcILU40nA9rAUsRXBfM ggug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738850363; x=1739455163; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yiwqOK4FVjPPZWydFoWK7z8lcOGoGBb2vdMSdzrBdU8=; b=S/7UT9d9GoMa52aDiZ4YLvh2vHmp7evxRn2YEpYeCHQnzO9eFZuC8WmcWAloF4eKGf vcIy3qjU+onK4GRK/VuaV/bJWub+2LjIV/ip9Eehl5SQAGIchlGvZX1S2juG1LWB6oRJ E2LsFAq0hwyO3D4chg9WBXfN5hhiDGtXq0W24VcudD0jTsYX9HI52G7gRb3TgdLLH2KE dCldMmaJPM9SJisa3hr0VtHOGHsr6Zdl71z9FrGaKK9DoqYpIWBMqWcBCXmNDFGsdkGj f93jhaGQhIMhK3Kf/6cOmiiPoDi8gxg1NZEeH3p3gDBEi61ySH+HjL9E5mHhkJZ9zeFn jTSA== X-Forwarded-Encrypted: i=1; AJvYcCXMj8yBXfnyY9neM9EmUcCbKNJb5iLIzE9iMbpdnJUv7EKxR/6ewdufH3btFBbO6s5+peGkS77VbCiA/EM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx770HwNChRnwhU56SvjPGorvKZBeSqFnJ9rG/1KtgI+UO09D38 R6fGaWJaUPrFZy5YWo6260l314WSZTzYbJEyVFMhFWCUHEHmCs/xGCbE3U4l+hw= X-Gm-Gg: ASbGncvXSiGGXkqvbyeLpcqOojpy3Qv8iD7uMiUxPJDlOksIT8F8CoHgiKwr9QU13oO zod1508dVrU1A/LetrzZVyr/kETMonoLQMvuY9V7dA1gw8g1gd6zo9ido0oW/z+BqIucoC6Nwod lgeS0MFXdEnOu5d7osBpdU5iYAdhX3V51F61Cpdj48hdYFb/1ZPsDy2iKDgbABH5F5fLzzUIjz/ ABKKB5MLR6bLtn/5fY30UVHNp5Y8ZC+Lk65tzFdkg6igAdnhCODV4dEz5UJcIGPK/8gldUVJy7o dA8qZ2WRpcwjQw== X-Google-Smtp-Source: AGHT+IEQ/bjSZV+56yIOq5wwNb3seJyTMrV6PD6QY8xe23aPssG7mgZFZVTL2HkADa9VSfJyXBrBsw== X-Received: by 2002:a05:600c:4f8e:b0:438:ad4d:cf01 with SMTP id 5b1f17b1804b1-4390d433b21mr58938875e9.7.1738850362808; Thu, 06 Feb 2025 05:59:22 -0800 (PST) Received: from linaro.org ([86.123.96.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4391da965a6sm20583685e9.6.2025.02.06.05.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 05:59:22 -0800 (PST) Date: Thu, 6 Feb 2025 15:59:21 +0200 From: Abel Vesa To: Johan Hovold Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak Subject: Re: [PATCH] arm64: dts: qcom: x1e80100: Add the watchdog device Message-ID: References: <20250206-x1e80100-add-watchdog-v1-1-77147510c2d7@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 25-02-06 11:44:18, Johan Hovold wrote: > On Thu, Feb 06, 2025 at 12:37:13PM +0200, Abel Vesa wrote: > > From: Rajendra Nayak > > > > The X Elite implements Server Base System Architecture (SBSA) specification > > compliant generic watchdog. > > > > Describe it. > > > > Signed-off-by: Rajendra Nayak > > Signed-off-by: Abel Vesa > > --- > > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > index 9d38436763432892ceef95daf0335d4cf446357c..007815699e4b9137c3b5cf72263c9dd3a64e6bb3 100644 > > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > @@ -3708,6 +3708,13 @@ pcie4_phy: phy@1c0e000 { > > status = "disabled"; > > }; > > > > + watchdog@1c840000 { > > Please keep the nodes sorted by unit address. Looks like this ones goes > much further down. Oups. Yes, you are right. Will move and respin. > > > + compatible = "arm,sbsa-gwdt"; > > + reg = <0 0x1c840000 0 0x1000>, > > + <0 0x1c850000 0 0x1000>; > > + interrupts = ; > > + }; > > + > > tcsr_mutex: hwlock@1f40000 { > > compatible = "qcom,tcsr-mutex"; > > reg = <0 0x01f40000 0 0x20000>; > > Johan Thanks for reviewing, Abel