From: Sean Christopherson <seanjc@google.com>
To: fuqiang wang <fuqiang.wng@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
wangfuqiang49 <wangfuqiang49@jd.com>
Subject: Re: [PATCH] kvm: delete unused variables iommu_noncoherent in struct kvm_arch
Date: Thu, 6 Feb 2025 07:16:23 -0800 [thread overview]
Message-ID: <Z6TSR8UmtNNHFeUQ@google.com> (raw)
In-Reply-To: <20250206022656.3752383-1-fuqiang.wng@gmail.com>
On Thu, Feb 06, 2025, fuqiang wang wrote:
> The code of legacy device assignment is deleted entirely in commit
> ad6260da1e23 ("KVM: x86: drop legacy device assignment") and the
> variable iommu_noncoherent in struct kvm_arch is also not referenced by
> any other code. So it is deleted in this patch.
Someone else beat you to it by a few weeks, I just haven't applied the patch
yet. Thanks!
https://lore.kernel.org/all/20250124075055.97158-1-znscnchen@gmail.com
>
> Signed-off-by: wangfuqiang49 <wangfuqiang49@jd.com>
> ---
> arch/x86/include/asm/kvm_host.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index b15cde0a9b5c..98555afb6f10 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1354,7 +1354,6 @@ struct kvm_arch {
> u64 shadow_mmio_value;
>
> struct iommu_domain *iommu_domain;
> - bool iommu_noncoherent;
> #define __KVM_HAVE_ARCH_NONCOHERENT_DMA
> atomic_t noncoherent_dma_count;
> #define __KVM_HAVE_ARCH_ASSIGNED_DEVICE
> --
> 2.47.0
>
prev parent reply other threads:[~2025-02-06 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 2:26 [PATCH] kvm: delete unused variables iommu_noncoherent in struct kvm_arch fuqiang wang
2025-02-06 15:16 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6TSR8UmtNNHFeUQ@google.com \
--to=seanjc@google.com \
--cc=fuqiang.wng@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=wangfuqiang49@jd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox