Re: [PATCH v1 1/1] kthread: Return the assigned value rather than 0

Andy Shevchenko
2025-02-07T19:02:07Z

On Fri, Feb 07, 2025 at 07:32:27PM +0100, Frederic Weisbecker wrote:
> Le Fri, Feb 07, 2025 at 04:40:14PM +0200, Andy Shevchenko a écrit :
> > On Tue, Feb 04, 2025 at 04:28:37PM +0200, Andy Shevchenko wrote:
> > > On Tue, Feb 04, 2025 at 01:45:13AM +0100, Frederic Weisbecker wrote:
> > > > Le Mon, Feb 03, 2025 at 06:48:55PM +0200, Andy Shevchenko a écrit :
> > > > > Recently introduced kthread_affine_preferred() has a bug that the value
> > > > > of ret variable set but not used. This breaks the compilation with error
> > > > > (assume default CONFIG_WERROR=y and `make W=1` to run the build):
> > > > >
> > > > > kernel/kthread.c:862:6: error: variable 'ret' set but not used [-Werror,-Wunused-but-set-variable]
> > > > >
> > > > > Fixes: 4d13f4304fa4 ("kthread: Implement preferred affinity")
> > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > >
> > > > Thanks but I already have it queued there:
> > > >
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git/commit/?h=kthread/fixes&id=1b0332a42656b798bea867631d739de023633ec6
> > > >
> > > > I'll do a pull request shortly.
> > >
> > > I'm fine with any approach as long as the issue will be fixed rather sooner.
> >
> > Any news? As of today no appearance of the (alternative) fix either in upstream,
> > or in Linux Next. What's the plan, please?
>
> It's there for a week or so. I must confess I should have advertized it:
>
> 1b0332a42656 ("kthread: Fix return value on kzalloc() failure in kthread_affine_preferred()")

Thank you, I see it now!