Re: [PATCH v1 1/1] kthread: Return the assigned value rather than 0

Andy Shevchenko
2025-02-04T14:28:59Z

On Tue, Feb 04, 2025 at 01:45:13AM +0100, Frederic Weisbecker wrote:
> Le Mon, Feb 03, 2025 at 06:48:55PM +0200, Andy Shevchenko a écrit :
> > Recently introduced kthread_affine_preferred() has a bug that the value
> > of ret variable set but not used. This breaks the compilation with error
> > (assume default CONFIG_WERROR=y and `make W=1` to run the build):
> >
> > kernel/kthread.c:862:6: error: variable 'ret' set but not used [-Werror,-Wunused-but-set-variable]
> >
> > Fixes: 4d13f4304fa4 ("kthread: Implement preferred affinity")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Thanks but I already have it queued there:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git/commit/?h=kthread/fixes&id=1b0332a42656b798bea867631d739de023633ec6
>
> I'll do a pull request shortly.

I'm fine with any approach as long as the issue will be fixed rather sooner.