The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andrea Righi <arighi@nvidia.com>
To: Tejun Heo <tj@kernel.org>
Cc: David Vernet <void@manifault.com>,
	Changwoo Min <changwoo@igalia.com>,
	linux-kernel@vger.kernel.org, sched-ext@meta.com
Subject: Re: [PATCH sched_ext/for-6.14-fixes 1/2] sched_ext: Implement auto local dispatching of migration disabled tasks
Date: Fri, 7 Feb 2025 23:59:56 +0100	[thread overview]
Message-ID: <Z6aQbFDeYADDlJJu@gpd3> (raw)
In-Reply-To: <Z6aMtxceyZsi5PfC@slm.duckdns.org>

On Fri, Feb 07, 2025 at 12:44:07PM -1000, Tejun Heo wrote:
...
> > I'm also a bit conflicted if the default should be on or off, we're
> > changing the previous behavior, but OTOH this is going to prevent some
> > potential breakage (due to the nr_cpus_allowed mismatch) and server
> > workload is going to benefit from this, so it seems that there are more
> > pros than cons at dispatching migration_disabled tasks directly by default.
> 
> Hmm.. I didn't see a lot of migrate_disable() while testing with stress-ng
> and migrate_disable() isn't used that much in the kernel to begin with. Do
> you happen to know where migrate_disable() was coming from when you saw them
> with bpfland?

I also don't see a lot of migrate_disable() invocations, but if I do the
usual benchmark, measuring the fps while building the kernel, with the
migration_disabled tasks dispatched directly I see a significant
performance drop in the fps and the kernel build is faster, so it seems
something related to the IO? I'll investigate a bit...

-Andrea

      reply	other threads:[~2025-02-07 23:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07 20:58 [PATCH sched_ext/for-6.14-fixes 1/2] sched_ext: Implement auto local dispatching of migration disabled tasks Tejun Heo
2025-02-07 20:59 ` [PATCH sched_ext/for-6.14-fixes 2/2] sched_ext: Fix migration disabled handling in targeted dispatches Tejun Heo
2025-02-09  6:33   ` Tejun Heo
2025-02-07 22:36 ` [PATCH sched_ext/for-6.14-fixes 1/2] sched_ext: Implement auto local dispatching of migration disabled tasks Andrea Righi
2025-02-07 22:44   ` Tejun Heo
2025-02-07 22:59     ` Andrea Righi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6aQbFDeYADDlJJu@gpd3 \
    --to=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@meta.com \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox