From: Tejun Heo <tj@kernel.org>
To: Changwoo Min <changwoo@igalia.com>
Cc: void@manifault.com, arighi@nvidia.com, kernel-dev@igalia.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched_ext: Provides a sysfs 'events' to expose core event counters
Date: Mon, 10 Feb 2025 07:28:56 -1000 [thread overview]
Message-ID: <Z6o3WOGS5Pulha36@slm.duckdns.org> (raw)
In-Reply-To: <20250210143643.220994-1-changwoo@igalia.com>
Hello,
On Mon, Feb 10, 2025 at 11:36:43PM +0900, Changwoo Min wrote:
...
> +#define scx_attr_event_show(buf, at, events, kind) ({ \
> + sysfs_emit_at(buf, at, "%40s: %16llu\n", #kind, (events)->kind); \
> +})
It's nice to format things in tabular forms but things under /sys lean more
towards simpler formatting, so maybe just do "%s %16llu\n"?
> static struct attribute *scx_global_attrs[] = {
> &scx_attr_state.attr,
> &scx_attr_switch_all.attr,
> &scx_attr_nr_rejected.attr,
> &scx_attr_hotplug_seq.attr,
> &scx_attr_enable_seq.attr,
> + &scx_attr_events.attr,
This probably should belong to the root/ subdir as we'd probably want to
keep the event counter separate per scheduler instance in the
multi-scheduler future.
Thanks.
--
tejun
next prev parent reply other threads:[~2025-02-10 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 14:36 [PATCH] sched_ext: Provides a sysfs 'events' to expose core event counters Changwoo Min
2025-02-10 17:28 ` Tejun Heo [this message]
2025-02-11 0:57 ` Changwoo Min
2025-02-13 16:45 ` Tejun Heo
2025-02-14 7:07 ` Changwoo Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6o3WOGS5Pulha36@slm.duckdns.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox