Re: [PATCH V8 06/14] rust: Add bare minimal bindings for clk framework

Viresh Kumar
2025-02-10T08:06:40Z

On 07-02-25, 18:19, Danilo Krummrich wrote:
> On 2/7/25 10:24 AM, Viresh Kumar wrote:
> > On 07-02-25, 00:11, Danilo Krummrich wrote:
> > > On Thu, Feb 06, 2025 at 12:05:59PM -0800, Stephen Boyd wrote:
> > > > Quoting Danilo Krummrich (2025-02-06 03:52:41)
> > > > > On Thu, Feb 06, 2025 at 12:49:14PM +0100, Danilo Krummrich wrote:
> > > > > > On Thu, Feb 06, 2025 at 02:58:27PM +0530, Viresh Kumar wrote:
> >
> > > > > > > +/// A simple implementation of `struct clk` from the C code.
> > > > > > > +#[repr(transparent)]
> > > > > > > +pub struct Clk(*mut bindings::clk);
> > > > > >
> > > > > > Guess this should be Opaque<bindings::clk>.
> > > > >
> > > > > Sorry, I meant NonNull<bindings::clk>.
> > > >
> > > > NULL is a valid clk. It's like "don't care" in the common clk framework
> > >
> > > Thanks for clarifying!
> >
> > > Guess this should be Opaque<bindings::clk>.
> >
> > So it should be this now ?
>
> I actually meant NonNull<bindings::clk>, which I corrected in a subsequent mail,
> where Stephen pointed out that NULL is a valid value for a struct clk.

Ahh okay, so no changes required now. Thanks.

--
viresh