From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFF8E1F12F8; Tue, 11 Feb 2025 09:41:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739266876; cv=none; b=XTBrjzBg4Qt4MVuRUee9OGVfdvnWRZn/mtuUVvU2dvLq8gHnkr/HhzmpSZMfDTqjI6XFw1ltzaLp317BNsPbbWwPYp+tZ7vDMtobZbCNs2zf0KSrcYH+qGjRSZJ9TU1wL3l0akpcOvSvM6jyXS9pBfI8GH+rKmHXUvAyq8yy7kI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739266876; c=relaxed/simple; bh=IkAWydMGs1r5rb0BA93bcr9XHfndvLruvy5SdIueU3E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X75kak0Nz9T7ddrFJLGi2H52EPUtzRPEUahPfjvwczfO/zhjJnTOfC2eUWiqxot/9+88vszbiQ95tvJ97SdxXrPFcG0W2CXXf5gw8yggPkPDRbLFbFnx6m+j95IH97+ChOn6Gnl3kL/dLhpN04SHMaCbXv0RCE0g1M36JsP/y7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: izygP/I+T8W8FPtZp56Vmg== X-CSE-MsgGUID: F4+jS7SXTxSxelIc1J6FJQ== X-IronPort-AV: E=McAfee;i="6700,10204,11341"; a="50510266" X-IronPort-AV: E=Sophos;i="6.13,277,1732608000"; d="scan'208";a="50510266" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 01:41:10 -0800 X-CSE-ConnectionGUID: M4q0L3FITbuvBztdQMvbJg== X-CSE-MsgGUID: Cg7Uozc6SoWKjkvUHvaTwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="143364716" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 01:41:03 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1thmlH-0000000ASZ3-2ikX; Tue, 11 Feb 2025 11:40:59 +0200 Date: Tue, 11 Feb 2025 11:40:59 +0200 From: Andy Shevchenko To: David Lechner Cc: Linus Walleij , Bartosz Golaszewski , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , Nuno =?iso-8859-1?Q?S=E1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org Subject: Re: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8() Message-ID: References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> <20250210-gpio-set-array-helper-v3-5-d6a673674da8@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250210-gpio-set-array-helper-v3-5-d6a673674da8@baylibre.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Feb 10, 2025 at 04:33:31PM -0600, David Lechner wrote: > Use bitmap_get_value8() instead of accessing the bitmap directly. > > Accessing the bitmap directly is not considered good practice. We now > have a helper function that can be used instead, so let's use it. Thank you, LGTM (one minor thing you may address, or keep it as in the current variant of the patch), Reviewed-by: Andy Shevchenko ... > +#include > #include bitmap.h implies bitops.h -- With Best Regards, Andy Shevchenko