From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AC81194C6A for ; Tue, 11 Feb 2025 10:47:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739270867; cv=none; b=BRZHPIw6ac6HW3q4NLXs/tVRQ4B668mN/aQ1cvWh1/elyTutWnINNQxMr7HuL730k/7gjnCwHf1iJNSX4pXv7WgeKhrIQVAAEDiCvwrUNkSL8TZ5sOws2S2G09q1vIFyGyA30YbHzfSN4hLvOLvQEbm7hz2TDNKpBmK1WqYwPeg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739270867; c=relaxed/simple; bh=ERXBDq1Mcg0/vJ8uPXsn3dZsnhiLhJpZ9eph+R3ZJ+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PDbZkDm4owNDndrLRK3gO4pRgP7EoJrw9KCmjVQOePgGGd2ilfgXoR45MGx+XPQYfWyYYPeDx27SHXDGh0RNFT7oZylGQVnkXDRerGdGgLZbAN2XyilD3qtopSqDPsl37wgiMBG2Nfq+9qyKefGzmMh9SZ/U22/6qtfZwUZHOb0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=leV6LFQ4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="leV6LFQ4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D107C4CEDD; Tue, 11 Feb 2025 10:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739270866; bh=ERXBDq1Mcg0/vJ8uPXsn3dZsnhiLhJpZ9eph+R3ZJ+M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=leV6LFQ4x/pIfK6HBG/IVuvHxPOPi/8//nz54cKTVifNhf2wYXLyzhja5G3CpYRJB d9o5ZwClZxkKyp7Rg0HPhlZuduqeoico2z0wuC0jYGNgX33GBnbL4e9S/Kbkx6MxLT xIKm4X9ZnxV4k0QiekDYi0bVc9kqJZGMmOt3GJwNfo8tITel04/8PnGLX4nagmphnv KeJII12YtAx0ML+EHOFTX83MEFLmYrnXq3LD8TnEQp0++nP8W1lPKhP3J2KChZ5wyz nQG16srREgPnZRqK0l7VkLbGFb/UIkXGbLoJ71N4N1tpqaN11ZbjkxOUzA+WwX191U pQ8MhEVmPEx0w== Date: Tue, 11 Feb 2025 16:17:42 +0530 From: Vinod Koul To: Pei Xiao Cc: xiaopeitux@foxmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5] phy: freescale: fsl-samsung-hdmi: fix build error in fsl_samsung_hdmi_phy_configure_pll_lock_det Message-ID: References: <476dace4-92fb-4d92-a342-cffd6f77b8f1@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 11-02-25, 10:10, Pei Xiao wrote: > > 在 2025/2/11 01:02, Vinod Koul 写道: > > On 17-01-25, 10:15, Pei Xiao wrote: > >> 在 2025/1/17 09:59, Adam Ford 写道: > >>> On Mon, Jan 13, 2025 at 2:41 AM wrote: > >>>> From: Pei Xiao > >>>> > >>>> FIELD_PREP() checks that a value fits into the available bitfield, > >>>> but the index div equals to 4,is out of range. > >>>> > >>>> which gcc complains about: > >>>> In function ‘fsl_samsung_hdmi_phy_configure_pll_lock_det’, > >>>> inlined from ‘fsl_samsung_hdmi_phy_configure’ at > >>>> drivers/phy/freescale/phy-fsl-samsung-hdmi.c :470:2: > >>>> ././include/linux/compiler_types.h:542:38: error: call to ‘__compiletime_assert_538’ > >>>> declared with attribute error: FIELD_PREP: value too large for the field > >>>> 542 | _compiletime_assert(condition, msg, __compiletime_assert_, > >>>> __COUNTER__) > >>>> | ^ > >>>> ././include/linux/compiler_types.h:523:4: note: in definition of > >>>> macro ‘__compiletime_assert’ 523 | prefix ## suffix(); > >>>> | ^~~~~~ > >>>> ././include/linux/compiler_types.h:542:2: note: in expansion of macro > >>>> ‘_compiletime_assert’ > >>>> 542 | _compiletime_assert(condition, msg, __compiletime_assert_, > >>>> __COUNTER__) > >>>> > >>>> REG12_CK_DIV_MASK only two bit, limit div to range 0~3, > >>>> so build error will fix. > >>>> > >>> LGTM. > >>> > >>> Reviewed-by: Adam Ford > >> loop Vkoul for email address was written incorrectly. > > Thanks for looping in! > > > > Change looks good to me. Can you please revise the patch title. A patch > > title should describe the change we are making. Fix build error is not > > an apt title > > there so many  "Fix build error" : https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/?qt=grep&q=fix+build+error > > what we should revise? > > Like:*phy: freescale: fsl-samsung-hdmi: Limit PLL lock detection clock divider to valid range* That sounds better -- ~Vinod