Re: [PATCH 5/6] sched_ext: idle: Per-node idle cpumasks

Andrea Righi
2025-02-11T07:32:54Z

On Mon, Feb 10, 2025 at 11:57:42AM -0500, Yury Norov wrote:
...
> > > +/*
> > > + * Find the best idle CPU in the system, relative to @node.
> > > + */
> > > +s32 scx_pick_idle_cpu(const struct cpumask *cpus_allowed, int node, u64 flags)
> > > +{
> > > + nodemask_t unvisited = NODE_MASK_ALL;
>
> This should be a NODEMASK_ALLOC(). We don't want to eat up too much of the
> stack, right?

Ok, and if I want to initialize unvisited to all online nodes, is there a
better than doing:

nodemask_clear(*unvisited);
nodemask_or(*unvisited, *unvisited, node_states[N_ONLINE]);

We don't have nodemask_copy() right?

Thanks,
-Andrea