From: Sean Christopherson <seanjc@google.com>
To: Binbin Wu <binbin.wu@linux.intel.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org,
rick.p.edgecombe@intel.com, kai.huang@intel.com,
adrian.hunter@intel.com, reinette.chatre@intel.com,
xiaoyao.li@intel.com, tony.lindgren@intel.com,
isaku.yamahata@intel.com, yan.y.zhao@intel.com,
chao.gao@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/8] KVM: TDX: Handle KVM hypercall with TDG.VP.VMCALL
Date: Tue, 11 Feb 2025 15:48:46 -0800 [thread overview]
Message-ID: <Z6vh3ih37Xrmv4TJ@google.com> (raw)
In-Reply-To: <20250211025442.3071607-5-binbin.wu@linux.intel.com>
On Tue, Feb 11, 2025, Binbin Wu wrote:
> ---
> arch/x86/kvm/vmx/tdx.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c
> index 420ee492e919..daa49f2ee2b3 100644
> --- a/arch/x86/kvm/vmx/tdx.c
> +++ b/arch/x86/kvm/vmx/tdx.c
> @@ -964,6 +964,23 @@ fastpath_t tdx_vcpu_run(struct kvm_vcpu *vcpu, bool force_immediate_exit)
> return tdx_exit_handlers_fastpath(vcpu);
> }
>
> +static int complete_hypercall_exit(struct kvm_vcpu *vcpu)
> +{
> + tdvmcall_set_return_code(vcpu, vcpu->run->hypercall.ret);
> + return 1;
> +}
> +
> +static int tdx_emulate_vmcall(struct kvm_vcpu *vcpu)
> +{
> + kvm_rax_write(vcpu, to_tdx(vcpu)->vp_enter_args.r10);
> + kvm_rbx_write(vcpu, to_tdx(vcpu)->vp_enter_args.r11);
> + kvm_rcx_write(vcpu, to_tdx(vcpu)->vp_enter_args.r12);
> + kvm_rdx_write(vcpu, to_tdx(vcpu)->vp_enter_args.r13);
> + kvm_rsi_write(vcpu, to_tdx(vcpu)->vp_enter_args.r14);
> +
> + return __kvm_emulate_hypercall(vcpu, 0, complete_hypercall_exit);
Thanks for persevering through all the ideas and churn, I like how this turned
out!
next prev parent reply other threads:[~2025-02-11 23:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 2:54 [PATCH v2 0/8] KVM: TDX: TDX hypercalls may exit to userspace Binbin Wu
2025-02-11 2:54 ` [PATCH v2 1/8] KVM: x86: Have ____kvm_emulate_hypercall() read the GPRs Binbin Wu
2025-02-11 5:05 ` Huang, Kai
2025-02-11 10:23 ` Xiaoyao Li
2025-02-12 1:32 ` Binbin Wu
2025-02-12 3:12 ` Xiaoyao Li
2025-02-11 2:54 ` [PATCH v2 2/8] KVM: TDX: Add a place holder to handle TDX VM exit Binbin Wu
2025-02-11 2:54 ` [PATCH v2 3/8] KVM: TDX: Add a place holder for handler of TDX hypercalls (TDG.VP.VMCALL) Binbin Wu
2025-02-11 8:41 ` Chao Gao
2025-02-11 9:08 ` Binbin Wu
2025-02-11 23:46 ` Sean Christopherson
2025-02-12 2:21 ` Binbin Wu
2025-02-11 2:54 ` [PATCH v2 4/8] KVM: TDX: Handle KVM hypercall with TDG.VP.VMCALL Binbin Wu
2025-02-11 23:48 ` Sean Christopherson [this message]
2025-02-11 2:54 ` [PATCH v2 5/8] KVM: TDX: Handle TDG.VP.VMCALL<MapGPA> Binbin Wu
2025-02-11 6:54 ` Yan Zhao
2025-02-11 8:11 ` Binbin Wu
2025-02-11 8:59 ` Chao Gao
2025-02-12 0:46 ` Sean Christopherson
2025-02-12 5:16 ` Binbin Wu
2025-02-12 18:56 ` Sean Christopherson
2025-02-13 3:23 ` Binbin Wu
2025-02-13 5:11 ` Binbin Wu
2025-02-13 15:17 ` Sean Christopherson
2025-02-17 3:41 ` Binbin Wu
2025-02-19 0:29 ` Sean Christopherson
2025-02-19 0:49 ` Binbin Wu
2025-02-11 2:54 ` [PATCH v2 6/8] KVM: TDX: Handle TDG.VP.VMCALL<ReportFatalError> Binbin Wu
2025-02-12 0:18 ` Sean Christopherson
2025-02-12 5:37 ` Binbin Wu
2025-02-12 13:53 ` Sean Christopherson
2025-02-11 2:54 ` [PATCH v2 7/8] KVM: TDX: Handle TDX PV port I/O hypercall Binbin Wu
2025-02-11 2:54 ` [PATCH v2 8/8] KVM: TDX: Handle TDX PV MMIO hypercall Binbin Wu
2025-02-12 2:28 ` Chao Gao
2025-02-12 2:39 ` Binbin Wu
2025-02-13 21:41 ` Edgecombe, Rick P
2025-02-14 0:47 ` Binbin Wu
2025-02-14 1:01 ` Edgecombe, Rick P
2025-02-14 1:20 ` Binbin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6vh3ih37Xrmv4TJ@google.com \
--to=seanjc@google.com \
--cc=adrian.hunter@intel.com \
--cc=binbin.wu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=isaku.yamahata@intel.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=tony.lindgren@intel.com \
--cc=xiaoyao.li@intel.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox