From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Joel Granados <joel.granados@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reboot: hide unused hw_protection_attr
Date: Tue, 25 Feb 2025 01:00:06 +0000 [thread overview]
Message-ID: <Z70WFl8rOrZ9XCWV@google.com> (raw)
In-Reply-To: <20250224141849.1546019-1-arnd@kernel.org>
On Mon, Feb 24, 2025 at 03:16:09PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The reference to hw_protection_attr is inside of an #ifdef block,
> but the definition is not:
>
> kernel/reboot.c:1092:30: error: unused variable 'hw_protection_attr' [-Werror,-Wunused-variable]
> 1092 | static struct kobj_attribute hw_protection_attr = __ATTR_RW(hw_protection);
> | ^~~~~~~~~~~~~~~~~~
>
> Add another #ifdef to match the first.
>
> Fixes: 6f0ec17b2d82 ("reboot: add support for configuring emergency hardware protection action")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
prev parent reply other threads:[~2025-02-25 1:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 14:16 [PATCH] reboot: hide unused hw_protection_attr Arnd Bergmann
2025-02-25 1:00 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z70WFl8rOrZ9XCWV@google.com \
--to=tzungbi@kernel.org \
--cc=a.fatoum@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=joel.granados@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox