Re: [PATCH RESEND v6 2/4] input: apple_z2: Add a driver for Apple Z2 touchscreens

Aditya Garg
2025-02-24T08:04:31Z

Hi

> On 17 Feb 2025, at 5:08 PM, Sasha Finkelstein via B4 Relay <devnull+fnkl.kernel.gmail.com@kernel.org> wrote:
>
> From: Sasha Finkelstein <fnkl.kernel@gmail.com>
>
> Adds a driver for Apple touchscreens using the Z2 protocol.
>
> Signed-off-by: Janne Grunau <j@jannau.net>
> Reviewed-by: Neal Gompa <neal@gompa.dev>
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
> ---
> drivers/input/touchscreen/Kconfig | 13 +
> drivers/input/touchscreen/Makefile | 1 +
> drivers/input/touchscreen/apple_z2.c | 473 +++++++++++++++++++++++++++++++++++
> 3 files changed, 487 insertions(+)
>
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index 1a03de7fcfa66c0f60768be17d776a79e36e570e..6c885cc58f323b3628538d41460248f8ab1dbf7d 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -103,6 +103,19 @@ config TOUCHSCREEN_ADC
> To compile this driver as a module, choose M here: the
> module will be called resistive-adc-touch.ko.
>
> +config TOUCHSCREEN_APPLE_Z2
> + tristate "Apple Z2 touchscreens"
> + default ARCH_APPLE
> + depends on SPI
> + help
> + Say Y here if you have an Apple device with
> + a touchscreen or a touchbar.

If I understood correctly, this driver is for arm Mac’s Touch Bar.
Probably mention the same here, since we have separate drivers for x86 Macs upstream.

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/hid?h=next-20250221&id=1fd41e5e3d7cc556e43f4162ca28a41f4896c6ad

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/hid?h=next-20250221&id=8e9b9152cfbdc2a90a8acb68acbc1407ef67d139
> +
> + If unsure, say N.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called apple_z2.