Re: [PATCH 1/2] Input: goodix-berlin - fix comment referencing wrong regulator

Neil Armstrong
2025-01-03T09:26:16Z

On 03/01/2025 10:21, Luca Weiss wrote:
> In the statement above AVDD gets enabled, and not IOVDD, so fix this
> copy-paste mistake.
>
> Fixes: 44362279bdd4 ("Input: add core support for Goodix Berlin Touchscreen IC")
> Reported-by: Jens Reidel <adrian@travitia.xyz>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> drivers/input/touchscreen/goodix_berlin_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/goodix_berlin_core.c b/drivers/input/touchscreen/goodix_berlin_core.c
> index 3fc03cf0ca23fdbe36028a6228030d3ffb8d3a09..e273fb8edc6b92bcbad0fd35223a841d7da7d671 100644
> --- a/drivers/input/touchscreen/goodix_berlin_core.c
> +++ b/drivers/input/touchscreen/goodix_berlin_core.c
> @@ -263,7 +263,7 @@ static int goodix_berlin_power_on(struct goodix_berlin_core *cd)
> goto err_iovdd_disable;
> }
>
> - /* Vendor waits 15ms for IOVDD to settle */
> + /* Vendor waits 15ms for AVDD to settle */
> usleep_range(15000, 15100);
>
> gpiod_set_value_cansleep(cd->reset_gpio, 0);
>

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>