From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Subject: Re: [PATCH v1 1/1] watchdog: nic7018_wdt: tidy up ACPI ID table
Date: Tue, 25 Feb 2025 13:00:18 +0200 [thread overview]
Message-ID: <Z72iwgbvlYFCz5q0@smile.fi.intel.com> (raw)
In-Reply-To: <20250225095804.360899-1-andriy.shevchenko@linux.intel.com>
On Tue, Feb 25, 2025 at 11:58:04AM +0200, Andy Shevchenko wrote:
> Tidy up ACPI ID table:
> - drop ACPI_PTR() and hence replace acpi.h with mod_devicetable.h
> - remove explicit driver_data initializer
> - drop comma in the terminator entry
>
> With that done, extend compile test coverage.
...
> config NIC7018_WDT
> tristate "NIC7018 Watchdog"
> - depends on X86 && ACPI
> + depends on HAS_IOMEM
Oh, this should be HAS_IOPORT, compiling on X86 won't help to find this issue
:-)
> + depends on ACPI || COMPILE_TEST
> select WATCHDOG_CORE
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-02-25 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 9:58 [PATCH v1 1/1] watchdog: nic7018_wdt: tidy up ACPI ID table Andy Shevchenko
2025-02-25 11:00 ` Andy Shevchenko [this message]
2025-02-25 21:14 ` kernel test robot
2025-02-26 0:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z72iwgbvlYFCz5q0@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox