From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE43F2571D3 for ; Tue, 25 Feb 2025 13:50:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740491418; cv=none; b=SVLkQaRnurGfPY6mZBARacHvhq0ZS5ayIY+FYq6c682Si0harazIhE6G0rft514Rsi7D9byevpaI0zrs5H8pXTCpCPvX0XC1ddXPV8/RfdkX6a+nMrwJkNsGbmUXRjFH6K5ayD7I4r5Rxg8nb4OC37egJpcGuXcjY2soPiUmpdM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740491418; c=relaxed/simple; bh=AnrO1R+eYOIRoqSXgbhD5fZn5x01gW/jo/i+D2bdYGo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jYdusixpZ76wm3hCGKOiuww+Z742XweOs3yHK4ZZtJiPN9QX6tFHMliM9WMIyidARJGiAwqHg0UUcruykhwftEaFfEAKqiM2/pZtwfuvGxp8Bpn8lgfS63qfu4KVlgdftyWuQqAUx4WATKV9JpCOW0jj8JfVxf0BFGkz/JU6LOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=cS1Zij+j; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cS1Zij+j" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-438d9c391fcso54455e9.0 for ; Tue, 25 Feb 2025 05:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740491414; x=1741096214; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=flQTZ/IAOp+GXiZB2aYc0mgVQNYYPMmryd0DJ0XOL+c=; b=cS1Zij+jgJsa9DAEIzQHwNl/WaXsysiFSL2L+IZ7I2ybPSjeDCYP8HquFcR7FUA47U 9MlowhDCfkDuUVUFrTXSyeBZt+z91ilkbCLqOLiAung6UeqVTGKEJFL672hh+vFNTzc/ fBKyxWVOui5NIajELWPK0zfm6545XRs0ksnLOMUDwStEa8G7/+27olQii9zF11Md+NKd X41tmnq9Ex9DrY9DQRbjlHWt1wugXLchMFQx9CoIZtQYpJOD90SzrfOzVZt3pn4cFLrx kCzXRRlRQza+4RZO8DL9xIv0hRmNRaQLoRJ9pY4pvCAzstWWL2PRdZoru/X5ysTWwAxx 6iEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740491414; x=1741096214; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=flQTZ/IAOp+GXiZB2aYc0mgVQNYYPMmryd0DJ0XOL+c=; b=Lmysa0J1mn81fYxb0c2Q8bCsqgrCk9EMrY5HQha1LuP/rHExexrPAO3g+r6zT5FwOU DQ4HviXdhb/eFJvK1mpHQibsAwRGwgBd/3ADabV3coVciyHNlrfKBC3YEEjpeVLTnUrX 8oG7NhptbH+UqpMG99KjjgOop3puS5eCHln3RgYyKz6oNlqwSX8EfjCJI2so6JI6sCsa 6OYq4RnHR2trhmkVWhWWPDIdLqoWL1gUdPNhBi19x2UmKqe5ox8kQV/lXBtsm0+NGsgD mr97k25lR6BAcN1cO8hDHGuKombboiwLQIZpWNHJc2uuVbdK95GycpNwhsgVeDXVkKxR rHjw== X-Forwarded-Encrypted: i=1; AJvYcCWmG0cOt5YbSiLn6QFYNpcScr/ci/KGMXd37FA3HyAHf+mZouU41rNVmrpF0uDQiYXkMslelW6NGWyxoXA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx309NaBNXM84BnVKQcHeYnh7/7+wwRLlsCMkB6jGjSHEbHZEmO 4M/qEhJXh4/pXaVz3inHmBd12ZsGqQ05wZqvduDO2Sb9pH8D8ghdMT/Un2Ec5A== X-Gm-Gg: ASbGncsRR0ZVQ/oD/H6HVRZjRx0moBn11/X0SXceh82tYapaOn2L0nBozUn9D5dOJjH jCRx6MHwLdTFjtnkezCQq9Tx0PO0Q5tuaf3RnDZc9LiE0hDo1Wv7FR/CMlLohjIWD291po+bRHW FrQLNMQjw1B09XQQweQn2aVwBEQRyczqlW11w5RJFBf2KAQJOAJ2U/DjRqZ/dIq/PLgZ/J3Iw8K veNzzArcupTksN0m7huP+eDdsqoPpc7jYIsipXiFMHLixJuKrbjGHhzyINl1qqldaVIW7PNQjcZ jCd9vfwPxkN9mSP0b/jhWdNYCl8FR0EhfaCS84n8acHH0bKSBYYvbD+SOLM2Yg== X-Google-Smtp-Source: AGHT+IEVNqBoimy0tPc+jYLAvU92qKQ9P0Hox3Z1GFrcZRjdTqreOTBPA7teWDprvJFrjRs+a6mDNw== X-Received: by 2002:a05:600c:920:b0:439:6017:6687 with SMTP id 5b1f17b1804b1-43ab10495c5mr1353355e9.7.1740491414136; Tue, 25 Feb 2025 05:50:14 -0800 (PST) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390cd8fbcabsm2312660f8f.86.2025.02.25.05.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 05:50:13 -0800 (PST) Date: Tue, 25 Feb 2025 13:50:09 +0000 From: Brendan Jackman To: Johannes Weiner Cc: Andrew Morton , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm: page_alloc: group fallback functions together Message-ID: References: <20250225001023.1494422-1-hannes@cmpxchg.org> <20250225001023.1494422-4-hannes@cmpxchg.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250225001023.1494422-4-hannes@cmpxchg.org> On Mon, Feb 24, 2025 at 07:08:26PM -0500, Johannes Weiner wrote: > The way the fallback rules are spread out makes them hard to > follow. Move the functions next to each other at least. > > Signed-off-by: Johannes Weiner Moving code makes blame more tiresome so I wouldn't personally do this, but if others find it helpful it's fine by me. Reviewed-by: Brendan Jackman ("Reviewed" means "git tells me there are no new lines nor totally deleted lines").