From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71CDC166F29 for ; Tue, 25 Feb 2025 17:52:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740505949; cv=none; b=nd5aqY2+Di40F4IXVNv3/cXQwzBy4CE57h4Jrig+GTqDyH6eaadMmtXgS9rLpTSqU9RB8zVmAJZl23+rRrr3uqbBMSmc29VRrIh0AbIJCTGW5lrrHM073Si/M/uSt6VV/sYJqXPFIbWOlsoR4ipO+RqP2YAp551dlwNkcV8rI6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740505949; c=relaxed/simple; bh=TITnbcgolKPMPksTb0kVckLbIOLQEkwI2FcyCceIkT4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PDw0pqf+ekXr2rJxIvDKeTecFdrPzpQ4Ft4KU+419t8OgCY3akQkcExMTDjKF0cpxGmjfolbGafQ6IZwxUC4Ez0cv9j10oVbgD86zKWYKf/k0oOy//r+7W+9lxr+jjG0K9OmW2hE82CuBwTuaco05XkrrVkIyRPOXhUmmt9KKlg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Nt80qRTs; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Nt80qRTs" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-221ac1f849fso1795ad.1 for ; Tue, 25 Feb 2025 09:52:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740505948; x=1741110748; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dN8nBA+Qh6D4N+wqpSDyJLyiHWYbmS4OUKXh0N+DSqI=; b=Nt80qRTsdIMKwK77eOr5LzLlJ6jv6oZ1XHDd6JlCzx539zK4aJJyWsue9Zgfdk2bNZ /hGVuCPln+75Wikzcy+h5VjgkFl6JnaCzXw5kkA/bWco+Pr8zsaL1TRrP8Vs26Kwt2Uf ZCh3SNk3gj/QHBWnV32g7+9XZLcqSbOvlMlSiwfDQcP4j5+/8mZuHlgdhtGZVbosLN4b YijJmCwdSeGE1PM9npYMVeeXv18y+YSX7Cxpc1iFn/2RWwp5+0JvQI4+EtO6k1uSmWtT /nkdvxmIEiqivOK5B+R5cf5yNBCHijxkPzGB7A62mx4+/f+Lf8l0TCMRqHL3+Z86IkCL QBiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740505948; x=1741110748; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dN8nBA+Qh6D4N+wqpSDyJLyiHWYbmS4OUKXh0N+DSqI=; b=ofTQ/SBasBuV6RSKG3zX2Qb7sp8eqTyMX1DMrbocLlwQNl/tsQpO8aU6YTmWupC5sz S/g7akz+0TabLVK8pEzT/eY1gqTWJWpjw8ABIamUaGXBIuwtaXcH37cONaxRf+Cn4zwY J5LBydDuhdqGKYBAGkrpOtiLHPVEONCY1tVeVJ3r8SOlNAlbPnAhe8pWCj2UROCjrSG+ 6H9KsErWZ7j0+OTlD9ZhzGXklQJjDP1srLfZa9XuMZsMVKQAhcBHMbmVfY7lHjr7XNGa OyvbBSEVrUmLMPegTH1gnlNGehkGXIm/KE1MO1yE5SPGUZpB1To1uxDqrolV61eI8a6O sMjA== X-Forwarded-Encrypted: i=1; AJvYcCVkSBF2mOOrChN1prRv3CVBwCG2E3Xi18zeiGZb7qpnAOHKqPxDUWhfHqknNu12vJDk01Pwpeu68axHYPI=@vger.kernel.org X-Gm-Message-State: AOJu0YzK3oJ9eeynDrmhhYUEvNCWNWrTIw0ClphY2UvIWOavA9gZ//Xl JiR75AL/RCKR+qZpA/WJdkJEcZINHvy65pEdyaPIYH/wiLbugnqgmzDH4uT7EQ== X-Gm-Gg: ASbGncsPZG+Hso7zDw/fWw+s+mKORgrzpUBvZjB1IbktfV0pIgRnUdZGGf2TGZ0rMAu 2ko/vCHf8bZzEiYYHcV5XgA7jcyzRtEsAF/+fzawPHV4j/EFRt2znbpDQZ/qJp7pAkUk/AARREs okMpPfe0vWWM/HfWKkbOdmHRMYWgJTeMvKs3qDZeVuE8a9SA8P61l2sAi9lE3DYJmDn85A+WUCk AEm0Zni2zB5BYlUu32ZEuuGfenxW6pdye8icby0Nc4eQrnxMjPvah8LHxy+1RlquicPDI0goByi FlXWXIjdr7c/fm46MMgzJbPApb6odHXshN1UH26IS0KaT9SYgt9q9niUQio5uaQ= X-Google-Smtp-Source: AGHT+IHCwCn1SF2NMONCzfAyHzGrJNS1HAUTJPist+TAdk8bMDyf0wMytHFuTMKOTPJoVoDGnbqb0g== X-Received: by 2002:a17:903:244d:b0:216:48d4:b3a8 with SMTP id d9443c01a7336-22307a60187mr3928025ad.16.1740505947317; Tue, 25 Feb 2025 09:52:27 -0800 (PST) Received: from google.com (169.224.198.35.bc.googleusercontent.com. [35.198.224.169]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fe6a43ccb3sm1861445a91.39.2025.02.25.09.52.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 09:52:26 -0800 (PST) Date: Tue, 25 Feb 2025 17:52:16 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: jgg@nvidia.com, kevin.tian@intel.com, corbet@lwn.net, will@kernel.org, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, eric.auger@redhat.com, jean-philippe@linaro.org, mdf@kernel.org, mshavit@google.com, shameerali.kolothum.thodi@huawei.com, smostafa@google.com, ddutile@redhat.com, yi.l.liu@intel.com, patches@lists.linux.dev Subject: Re: [PATCH v8 12/14] iommu/arm-smmu-v3: Introduce struct arm_smmu_vmaster Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 25, 2025 at 09:25:40AM -0800, Nicolin Chen wrote: > Use it to store all vSMMU-related data. The vsid (Virtual Stream ID) will > be the first use case. Since the vsid reader will be the eventq handler > that already holds a streams_mutex, reuse that to fenche the vmaster too. > > Also add a pair of arm_smmu_attach_prepare/commit_vmaster helpers to set > or unset the master->vmaster point. Put these helpers inside the existing > arm_smmu_attach_prepare/commit(). > > For identity/blocked ops that don't call arm_smmu_attach_prepare/commit(), > add a simpler arm_smmu_master_clear_vmaster helper to unset the vmaster. > > Reviewed-by: Jason Gunthorpe > Reviewed-by: Pranjal Shrivastavat > Signed-off-by: Nicolin Chen > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 28 ++++++++++++ > .../arm/arm-smmu-v3/arm-smmu-v3-iommufd.c | 45 +++++++++++++++++++ > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 18 +++++++- > 3 files changed, 90 insertions(+), 1 deletion(-) > Apologies for my spelling error in [1]. It's supposed to be: Reviewed-by: Pranjal Shrivastava For all the other patches too. Correct spelling in [2]. Thanks, Praan [1] https://lore.kernel.org/all/Z73zvIbsXzJMCaNt@google.com/ [2] https://lore.kernel.org/all/Z730M3XptvDRObBp@google.com/