Re: [PATCH 1/2] rust/faux: Drop #[repr(transparent)] from faux::Registration

Fiona Behrens
2025-02-26T13:00:33Z

Lyude Paul <lyude@redhat.com> writes:

> I think this change got missed during review, we don't need
> #[repr(transparent)] since Registration just holds a single NonNull. This
> attribute had originally been added by me when I was still figuring out how
> the bindings should look like but got committed by mistake. So, just drop
> it.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Reviewed-by: Fiona Behrens <me@Kloenk.dev>

> ---
> rust/kernel/faux.rs | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/rust/kernel/faux.rs b/rust/kernel/faux.rs
> index 5acc0c02d451f..41751403cd868 100644
> --- a/rust/kernel/faux.rs
> +++ b/rust/kernel/faux.rs
> @@ -19,7 +19,6 @@
> /// `self.0` always holds a valid pointer to an initialized and registered [`struct faux_device`].
> ///
> /// [`struct faux_device`]: srctree/include/linux/device/faux.h
> -#[repr(transparent)]
> pub struct Registration(NonNull<bindings::faux_device>);
>
> impl Registration {