From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Benjamin Tissoires <bentiss@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Takashi Iwai <tiwai@suse.de>,
Jonathan Denose <jdenose@google.com>,
Erick Archer <erick.archer@outlook.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RESEND] Input: synaptics: hide unused smbus_pnp_ids[] array
Date: Tue, 25 Feb 2025 12:59:41 -0800 [thread overview]
Message-ID: <Z74vPf6-qETZG0t1@google.com> (raw)
In-Reply-To: <20250225145451.1141995-1-arnd@kernel.org>
On Tue, Feb 25, 2025 at 03:54:38PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When SMBUS is disabled, this is never referenced, causing a W=1 warning:
>
> drivers/input/mouse/synaptics.c:164:27: error: 'smbus_pnp_ids' defined but not used [-Werror=unused-const-variable=]
>
> Hide the array behind the same #ifdef as the code referencing it.
>
> Fixes: e839ffab0289 ("Input: synaptics - add support for Intertouch devices")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2025-02-25 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 14:54 [PATCH] [RESEND] Input: synaptics: hide unused smbus_pnp_ids[] array Arnd Bergmann
2025-02-25 20:59 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z74vPf6-qETZG0t1@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bentiss@kernel.org \
--cc=erick.archer@outlook.com \
--cc=jdenose@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox