From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [213.95.27.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D1B318DB11 for ; Wed, 26 Feb 2025 07:20:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.27.120 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740554406; cv=none; b=UtDmhkUEqdRGT1OnaKvZjPVq7JiTyq3g8Vnisw0Qsq91NSkg7GrLScsTxz//Qpu0azehu/gBg5VWGj9FC8JLHJbUw73kuJ7cktcTC7VxCkJVoHDGq0OB31SrMQ2PBXc/Of4W1y/m3WMJrDbJZJVoT5tl37F7qfgRw1ec5hd5yZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740554406; c=relaxed/simple; bh=zC5JXssWPYpS9SK9DWLWBz2AMT0TmxOYeJ7KFZBG0k4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VSUfA1QxyeLvJ+6XxuSgvbiPKdyw0FdKxkHf8zPULabxLPZvWl+TBGabLSOcV2vlRAtbMKBeGLvxBJJ3frVv1UQi4taHutcS9aMcdP+JqTDUlXXgvkISmDHQCt73jrT857W8bAPRnTEIGHRU+WKCf2+1WsOHdTRCWnVqDn6KB8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gnumonks.org; spf=pass smtp.mailfrom=gnumonks.org; arc=none smtp.client-ip=213.95.27.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gnumonks.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gnumonks.org Received: from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.94.2) (envelope-from ) id 1tnBi2-00A4ao-CA; Wed, 26 Feb 2025 08:19:58 +0100 Received: from laforge by nataraja.fritz.box with local (Exim 4.98) (envelope-from ) id 1tnBaU-00000000m4J-0Bjp; Wed, 26 Feb 2025 08:12:10 +0100 Date: Wed, 26 Feb 2025 08:12:10 +0100 From: Harald Welte To: "Dr. David Alan Gilbert" Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, david@rowetel.com, Tzafrir Cohen Subject: Re: users of drivers/misc/echo ? Message-ID: References: <07afd3cb-3ab1-4dc9-b0c1-3fef2d52f60b@app.fastmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Dave, On Tue, Feb 25, 2025 at 10:04:07PM +0000, Dr. David Alan Gilbert wrote: > * Harald Welte (laforge@gnumonks.org) wrote: > > Hi Dave, > > > > On Tue, Feb 25, 2025 at 06:39:06PM +0000, Dr. David Alan Gilbert wrote: > > > > Actually, looking at DAHDI, I really don't think anyone is still using > > > > the dahdi_echocan_oslec code. It is disabled by default and only built > > > > if explicitly enabled by the user, and indeed if anyone did that it > > > > would fail to build for any kernels that have moved it out of staging. > > > > > > It looks like Debian is including and enabling it in it's DKMS build: > > > > thanks, I didn't realize that. You could reach out to the Debian maintainer of the package > > if you'd want clarification. > > Given that Debian build etc - what's your preference? I'm happy to > grind a patch to remove the kernel copy if Debian is using their own copy. > Or do we leave it and fix up Debian to use it? I've Cc'ed Tzafrir, the Debian maintainer of the DAHDI package. Better to ask his opinion directly rather than speculate about it. Tzafrir: You can read this thread on lkml.org. The summary is that mainline Linux is considering to remove drivers/misc/echo from the kernel source, as after removal of mISDN there are no users of it left in mainline. DAHDI doesn't build the dahdi_echocan_oslec by default, and the Debian dahdi-linux DKMS seems to come with its own copy/version of the actual oslec echo cancellation code rather than using the mainline one (which has migrated from staging to misc a decade ago). My opinion is that there's no reason mainline should keep drivers/misc/echo. Regards, Harald -- - Harald Welte https://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)