From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: lee@kernel.org, giometti@enneenne.com,
gregkh@linuxfoundation.org, raymond.tan@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/4] mfd: intel-ehl: Introduce Intel Elkhart Lake PSE GPIO and TIO
Date: Wed, 26 Feb 2025 15:22:24 +0200 [thread overview]
Message-ID: <Z78VkEnJh8l9MWF7@smile.fi.intel.com> (raw)
In-Reply-To: <Z78VIjgkzf_GlauU@smile.fi.intel.com>
On Wed, Feb 26, 2025 at 03:20:35PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 26, 2025 at 11:45:27AM +0530, Raag Jadav wrote:
...
> > +++ b/drivers/mfd/intel-ehl-gpio.c
>
> We are usually align the file name and Kconfig option, and I like Kconfig
> choice, so intel_ehl_pse_gpio.c (also note the style with other intel_$SOC_*
> files in the folder.
And also Subject, you have currently 3 different names for the same:
Kconfig, Subject, filename.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-02-26 13:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 6:15 [PATCH v1 0/4] Introduce Intel Elkhart Lake PSE TIO Raag Jadav
2025-02-26 6:15 ` [PATCH v1 1/4] pps: generators: tio: split pps_gen_tio.h Raag Jadav
2025-02-26 7:50 ` Rodolfo Giometti
2025-02-26 12:45 ` Andy Shevchenko
2025-02-27 5:08 ` Raag Jadav
2025-02-27 7:18 ` Andy Shevchenko
2025-02-26 6:15 ` [PATCH v1 2/4] pps: generators: tio: move to match_data() model Raag Jadav
2025-02-26 7:50 ` Rodolfo Giometti
2025-02-26 12:59 ` Andy Shevchenko
2025-02-26 6:15 ` [PATCH v1 3/4] pps: generators: tio: Introduce Intel Elkhart Lake PSE TIO Raag Jadav
2025-02-26 7:51 ` Rodolfo Giometti
2025-02-26 13:00 ` Andy Shevchenko
2025-02-26 6:15 ` [PATCH v1 4/4] mfd: intel-ehl: Introduce Intel Elkhart Lake PSE GPIO and TIO Raag Jadav
2025-02-26 13:20 ` Andy Shevchenko
2025-02-26 13:22 ` Andy Shevchenko [this message]
2025-02-27 5:13 ` Raag Jadav
2025-02-27 7:20 ` Andy Shevchenko
2025-02-27 14:03 ` Raag Jadav
2025-02-27 14:11 ` Andy Shevchenko
2025-02-26 13:21 ` [PATCH v1 0/4] Introduce Intel Elkhart Lake PSE TIO Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z78VkEnJh8l9MWF7@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raag.jadav@intel.com \
--cc=raymond.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox