Re: [PATCH net-next v4 05/15] net: phy: Create a phy_port for PHY-driven SFPs

["Russell King (Oracle)" <linux@armlinux.org.uk>]

On Thu, Feb 13, 2025 at 11:15:53AM +0100, Maxime Chevallier wrote:
> Some PHY devices may be used as media-converters to drive SFP ports (for
> example, to allow using SFP when the SoC can only output RGMII). This is
> already supported to some extend by allowing PHY drivers to registers
> themselves as being SFP upstream.
> 
> However, the logic to drive the SFP can actually be split to a per-port
> control logic, allowing support for multi-port PHYs, or PHYs that can
> either drive SFPs or Copper.
> 
> To that extent, create a phy_port when registering an SFP bus onto a
> PHY. This port is considered a "serdes" port, in that it can feed data
> to anther entity on the link. The PHY driver needs to specify the
> various PHY_INTERFACE_MODE_XXX that this port supports.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

With this change, using phy_port requires phylink to also be built in
an appropriate manner. Currently, phylink depends on phylib. phy_port
becomes part of phylib. This patch makes phylib depend on phylink,
thereby creating a circular dependency when modular.

I think a different approach is needed here.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!