From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CA0F42A97 for ; Sun, 16 Feb 2025 16:00:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739721608; cv=none; b=FO4uY88hpGNzuqLm2IZXuqOGX0E2h9adzSdKDxYmH4rqK+DVD2AXeUnDshRe3xdSNCjV4iwkqoYBKtMadG2U8I9+bzGXYD4mwtggUFHB+oheSnwF3bmgV5VAPLOfgary1syehYye7d8oziaiU3N6sAx52YZdPr9YXCQa7+/7C/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739721608; c=relaxed/simple; bh=EF26j1suwLuBzziUeMgwWp0X8x4RpIgeD8Jxuuo4ULs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S56An9R2NJIw8MulwsPtOJDkyUV1PaQM0dAE4PtRf2etqtfrY3sWQBBMNEsaKMnhNUSu9U5HDzOBSItj6zadcC7ohcACjl/t3+UFZNBUNsnXvSrA08gGp+f2LcDbDEcVjtSax+IzDliCcfNwSFmG4owLuhbVadC/Y85Vz9RrlAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net; spf=pass smtp.mailfrom=posteo.net; dkim=pass (2048-bit key) header.d=posteo.net header.i=@posteo.net header.b=pTgJM2RV; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.net header.i=@posteo.net header.b="pTgJM2RV" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5A1EE240028 for ; Sun, 16 Feb 2025 17:00:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1739721604; bh=EF26j1suwLuBzziUeMgwWp0X8x4RpIgeD8Jxuuo4ULs=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:From; b=pTgJM2RVrLprfYbMXybmlG4KLOjVo9E5qpqmA+ccmW85RElh5VpLIRz1jG+WN+S/n /1a+/Z7pYIDe5dnKfrSx017pXnXOnaK0Z4oSx9JPbq5XY211pMBp1oBmcel4YGxq52 F3RFdjVJ+IRnPS7aXKXN0RW4qOCHxnRfvy1KzqoSH8ARmyd2EiaZD4HdzFGgnbeGt1 EF0887xrzs+xoKfuvZWrJfWF4lUIF/f4kWYDcBTen21LugjWTYJ/6EFcuL+Jof8s8x Rz6Ymj2KIeS3xT0Ke1YT8gFrFa0zSQbesigmbblCfD+ohW23aPetTyHEH8BbIFFnzO aesaOV6qAm6Dw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Ywr8V6Vlfz9rxW; Sun, 16 Feb 2025 16:59:54 +0100 (CET) Date: Sun, 16 Feb 2025 15:59:54 +0000 From: =?utf-8?Q?J=2E_Neusch=C3=A4fer?= To: Rob Herring Cc: Crystal Wood , j.ne@posteo.net, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Krzysztof Kozlowski , imx@lists.linux.dev, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Krzysztof Kozlowski , Conor Dooley , Damien Le Moal , Niklas Cassel , Herbert Xu , "David S. Miller" , Lee Jones , Vinod Koul , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , =?utf-8?Q?J=2E_Neusch=C3=A4fer?= , Wim Van Sebroeck , Guenter Roeck , Mark Brown , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, linux-pci@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, Li Yang , John Ogness Subject: Re: [PATCH v2 09/12] dt-bindings: memory-controllers: Convert fsl,elbc to YAML Message-ID: References: <20250207-ppcyaml-v2-0-8137b0c42526@posteo.net> <20250207-ppcyaml-v2-9-8137b0c42526@posteo.net> <20250210215324.GA1040564-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250210215324.GA1040564-robh@kernel.org> On Mon, Feb 10, 2025 at 03:53:24PM -0600, Rob Herring wrote: > On Sun, Feb 09, 2025 at 02:31:34PM -0600, Crystal Wood wrote: > > On Fri, Feb 07, 2025 at 10:30:26PM +0100, J. Neuschäfer via B4 Relay wrote: > > > From: "J. Neuschäfer" > > > > > > Convert the Freescale localbus controller bindings from text form to > > > YAML. The updated list of compatible strings reflects current usage > > > in arch/powerpc/boot/dts/, except that many existing device trees > > > erroneously specify "simple-bus" in addition to fsl,*elbc. > > > > > > Changes compared to the txt version: > > > - removed the board-control (fsl,mpc8272ads-bcsr) node because it only > > > appears in this example and nowhere else > > > - added a new example with NAND flash > > > - updated list of compatible strings > > > > > > Signed-off-by: J. Neuschäfer > > > --- > > > > > > V2: > > > - fix order of properties in examples, according to dts coding style > > > - move to Documentation/devicetree/bindings/memory-controllers > > > - clarify the commit message a tiny bit > > > - remove unnecessary multiline markers (|) > > > - define address format in patternProperties > > > - trim subject line (remove "binding") > > > - remove use of "simple-bus", because it's technically incorrect > > > > While I admit I haven't been following recent developments in this area, > > as someone who was involved when "simple-bus" was created (and was on the > > ePAPR committee that standardized it) I'm surprised to hear simple-bus > > being called "erroneous" or "technically incorrect" here. > > Erroneous because the binding did not say "simple-bus" was used. Not > uncommon with the old .txt bindings. > > Generally, if a bus has control registers or resources like clocks, then > we tend not to call them 'simple-bus'. And '"specific-bus", > "simple-bus"' gives some problems around what driver if any do you > bind to. [...] > > You'd probably need something like commit 3e25f800afb82bd9e5f8 ("memory: > > fsl_ifc: populate child devices without relying on simple-bus") and the > > subsequent fix in dd8adc713b1656 ("memory: fsl_ifc: populate child > > nodes of buses and mfd devices")... > > > > I'm curious what the reasoning was for removing simple-bus from IFC. It > > seems that the schema verification also played a role in that: > > https://www.spinics.net/lists/devicetree/msg220418.html > > If a kernel change is needed to support changed .dts files, then we > shouldn't be doing that here (being mature platforms). That would mean > new DTB will not work with existing kernels. Alright, I'll keep simple-bus in the eLBC binding for historical compatibility. Thank you both for your discussion. J. Neuschäfer