From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53F2822AE59 for ; Tue, 18 Feb 2025 09:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739869648; cv=none; b=dZFlnOXM6Zv+zo7rqnpLpcXcPDtcxTO7BFiKOlYEKAZal6Ce4R+1IzSSoWy67gfyXhV/L6nEYN2AwxjhhmFkMJldP4JBsF8T8sIydoHiD/4C4bMarCQMgHEIaX346WpI8ds79T5AD3V4crTXxAWmj+k2DQYbYQc5junfwRVMvk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739869648; c=relaxed/simple; bh=zuwMhmH8w50LYsAFHKURsu2l9zRkMmG5Ds5XAKofXRk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jJa58+tbNUEuQOaR5QPW1YhgDLQUahvYQCHZR8jY8SjL9VBHYf8z6X+QoTa1hP1mixteHbdNPhOn7ZojuRIJIqsoYMl5WM6Ch2vLLC8fjhKH2Ev1zx3vWp/L+8Iso+Io/D+0HEwO2Xpx+FvH1L9B8uFp+vXgu902BJ7b1ot3sQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pis013iR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pis013iR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AECA5C4CEE2; Tue, 18 Feb 2025 09:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739869647; bh=zuwMhmH8w50LYsAFHKURsu2l9zRkMmG5Ds5XAKofXRk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pis013iRqbUbwFMPEPXWPcuFx2fqSMpj6sjL3SQ4jHJJJRW3JY+NYCM27XgX/KwMY hOLbylf9ZC/Z6v8oV2N6wsgaCrIlrCm+OTS57eNT5AIdm3fM7sWdjaXQlgC51xNN0a wDoJuGAU170FYk4fIR+93CINZCUtzg3MJbhzgivzT1MWeB80+T6TetVfXb8yu/USQu lFYKDJs+AS/0mQweKp4lwtf74GBkD6HCrMcYSpMKv+tl7ghqspdn+YKgKes5Y5Ytao 5ix9vViVF722wmzFJsIMzEvHlKOCgLMly9iJpAnfmA128tbCfMjIyT2T+ErjzOeQxL v4SgL9soBT63g== Date: Tue, 18 Feb 2025 10:07:17 +0100 From: Ingo Molnar To: Brian Gerst Cc: linux-kernel@vger.kernel.org, x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Borislav Petkov , Ard Biesheuvel , Uros Bizjak Subject: Re: [PATCH v6 06/15] x86/module: Deal with GOT based stack cookie load on Clang < 17 Message-ID: References: <20250123190747.745588-1-brgerst@gmail.com> <20250123190747.745588-7-brgerst@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250123190747.745588-7-brgerst@gmail.com> * Brian Gerst wrote: > #define R_X86_64_GOTPCREL 9 /* 32 bit signed pc relative > - offset to GOT */ > +#define R_X86_64_GOTPCRELX 41 offset to GOT */ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > +#define R_X86_64_REX_GOTPCRELX 42 Uhm, I'm pretty sure this won't even build, should any code use R_X86_64_GOTPCRELX - which it doesn't currently... Also, each entry here has a comment explaining it - except these two new GOTPCREL variants. Thanks, Ingo