From: Christoph Hellwig <hch@infradead.org>
To: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Dan Schatzberg <schatzberg.dan@gmail.com>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhaoyang Huang <huangzhaoyang@gmail.com>,
steve.kang@unisoc.com
Subject: Re: [PATCH] Revert "driver: block: release the lo_work_lock before queue_work"
Date: Tue, 18 Feb 2025 08:31:50 -0800 [thread overview]
Message-ID: <Z7S19ulXMAs7qy1H@infradead.org> (raw)
In-Reply-To: <20250218065835.19503-1-zhaoyang.huang@unisoc.com>
On Tue, Feb 18, 2025 at 02:58:35PM +0800, zhaoyang.huang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>
> This reverts commit ad934fc1784802fd1408224474b25ee5289fadfc.
>
> loop_queue_work should be strictly serialized to loop_process_work since
> the lo_worker could be freed without noticing new work has been queued
> again.
Btw, if you care about the lock contention you might want to split out
the trivial non-cgroup version into a separate helper or at least
branch and reduce the lock hold time there.
prev parent reply other threads:[~2025-02-18 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 6:58 [PATCH] Revert "driver: block: release the lo_work_lock before queue_work" zhaoyang.huang
2025-02-18 16:28 ` Jens Axboe
2025-02-18 16:31 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7S19ulXMAs7qy1H@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=huangzhaoyang@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=schatzberg.dan@gmail.com \
--cc=steve.kang@unisoc.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox